Opened 7 days ago

Closed 3 days ago

#15723 closed defect (fixed)

TINSEL: The in-game save menu in Discworld 1 becomes inaccessible on Android

Reported by: mim2011 Owned by: eriktorbjorn
Priority: normal Component: Engine: Tinsel
Version: Keywords:
Cc: Game: Discworld

Description

Discworld 1 CD DOS English
Scummvm master Linux / Windows
Scummvm Android

The in game menu for saving or loading works only 3 time, after that it can not be reached using 1 or 5 or F1 or F5. I just start the game and save 2 or 3 times in the first room, after that leave it and try to save again but the menu is not reachable any more.

Attachments (2)

dw-cd.001 (1.2 KB ) - added by mim2011 6 days ago.
dw-cd.002 (1.2 KB ) - added by mim2011 6 days ago.

Download all attachments as: .zip

Change History (15)

comment:1 by antoniou79, 7 days ago

There's been a mention of this issue on the ScummVM discord too starting here:
https://discord.com/channels/581224060529148060/1135579923185139862/1330121383002243162

The member Dorian Gray mentions that:

It seems I can narrow it down! The problem happens when you open the save dialogs and dismiss it without actually saving anything, it stays broken until it is restarted. Kinda annoying.

I haven't found time to do any testing myself.

comment:2 by antoniou79, 7 days ago

Summary: Discworld 1 save menuTINSEL: The in-game save menu in Discworld 1 becomes inaccessible

comment:3 by bluegr, 7 days ago

Summary: TINSEL: The in-game save menu in Discworld 1 becomes inaccessibleTINSEL: The in-game save menu in Discworld 1 becomes inaccessible on Android

I can't reproduce this under Windows. Seems to be present in the Android version of ScummVM only

comment:4 by mim2011, 7 days ago

I discovered the problem on Linux with an own build from master branch, and after that I reproduced it on Windows and Android with latest downloadable version for those platforms 2.9.0.

comment:5 by bluegr, 6 days ago

Can you provide more information?
Specifically:

  • which version of Discworld are you using? You mention English CD?
  • does that version have *.SCN or *.GRA files?
  • can you provide reproduction steps?

I tried to reproduce the error as follows:

  • Opened the save menu via F5
  • Saved
  • Repeated a couple of times
  • Reopened the save menu, and pressed cancel
  • Repeated a couple of times

I can't reproduce this issue with the steps outlined above

by mim2011, 6 days ago

Attachment: dw-cd.001 added

by mim2011, 6 days ago

Attachment: dw-cd.002 added

comment:6 by mim2011, 6 days ago

User picked target 'dw-cd' (engine ID 'tinsel', game ID 'dw')...
Running Discworld (CD/DOS/English)
dw.gra: c8808ccd988d603dd35dff42013ae7fd, 781656 bytes.
english.smp: 4710bd5cc788df1d517370d43abe1101, 343755891 bytes.
Failed to query the CD TOC: 21

I tried to reproduce it on Linux with debug level set to various values (4, 6, 8, 10, 11) but when the bug appear there where no messages in log about it.
I have attached the two save files that I got on Windows with version 2.9.0 and I can reproduced it only by loading a saved game with the in-game menu and after that the menu is inaccessible.

comment:7 by mim2011, 4 days ago

Inspired by this forum thread https://forums.scummvm.org/viewtopic.php?t=17287 I tested again with 2.8.1 on Windows, the saved games are working, and there there is no bug. It seems to be with only with 2.9.0

comment:8 by eriktorbjorn, 4 days ago

Maybe I'm imagining things, but there seems to be a difference between loading savegames by pressing the load button in the load dialog (works for me) and loading them by double-clicking the savegame (breaks things for me).

Edit: These actions take different paths through the code, so it does seem possible.

Last edited 4 days ago by eriktorbjorn (previous) (diff)

comment:9 by Torbjörn Andersson <eriktorbjorn@…>, 3 days ago

In 599df7ad:

TINSEL: Fix save/load menu becoming inaccessible (bug #15723)

When the save/load dialogs are displayed, the engine switches to a
different keymapper. It was only switched back when using the "X" button
to load a savegame, not when double-clicking on one. This made it
impossible to open the save/load dialogs again.

Now the keymap is restored in Dialogs::killInventory() instead. That
means it will be done even when not needed, but this is where we also
disable the virtual keyboard so it's presumably a good, well-tested spot
for it.

comment:10 by eriktorbjorn, 3 days ago

Owner: set to eriktorbjorn
Resolution: fixed
Status: newpending

comment:11 by Torbjörn Andersson <eriktorbjorn@…>, 3 days ago

In fd41e701:

TINSEL: Fix save/load menu becoming inaccessible (bug #15723)

When the save/load dialogs are displayed, the engine switches to a
different keymapper. It was only switched back when using the "X" button
to load a savegame, not when double-clicking on one. This made it
impossible to open the save/load dialogs again.

Now the keymap is restored in Dialogs::killInventory() instead. That
means it will be done even when not needed, but this is where we also
disable the virtual keyboard so it's presumably a good, well-tested spot
for it.

comment:12 by mim2011, 3 days ago

I can confirm that the change did fixed the problem. Tested on Linux. Thank you!

comment:13 by eriktorbjorn, 3 days ago

Status: pendingclosed

Thanks for confirming! Closing as fixed.

Note: See TracTickets for help on using tickets.