Opened 3 months ago
Closed 3 months ago
#15713 closed defect (fixed)
BLADERUNNER: The non-interactive demo no longer plays in fullscreen
| Reported by: | antoniou79 | Owned by: | antoniou79 |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Bladerunner |
| Version: | Keywords: | ||
| Cc: | Game: | Blade Runner |
Description
In recent daily builds of 2.10.0git on Windows (eg. from Jan 24th, 2025), the Blade Runner demo (non-interactive) available from the ScummVM web site, is not playing on full screen as it's supposed to.
It's instead playing in a smaller rectangle within the screen centered leaving the rest of the full screen surface black.
This is not an issue on ScummVM 2.9.0 stable release.
I intend to bisect for the cause in the following days.
Change History (1)
comment:1 by , 3 months ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
The bug was introduced by this commit:
https://github.com/scummvm/scummvm/commit/a81bfbe80577ae94138d705019bad3170e320c79
The calls to VQADecoder::close() (at the start of VQAPlayer::open(), and then when calling _decoder.loadStream() in the same method) delete the VQP table that was being allocated and populated (from the VQP file) before VQAPlayer::open() in outtake.cpp.
Thus, the initialization and populating of the VQP table is now moved after the VQAPlayer::open() call.
This affected only the non-interactive demo, which needs to parse the VQP file, and the playback of other old VQA videos that have accompanying VQP files.
This is now fixed by:
https://github.com/scummvm/scummvm/commit/0380f01e07a252fd068a64dffad715fa0ed8c116