Opened 4 weeks ago

Closed 2 weeks ago

Last modified 5 days ago

#15707 closed defect (fixed)

TUCKER: Unable to skip the 10 minute intro to Bud Tucker (2.9.0)

Reported by: RightSaidBrett Owned by: bluegr
Priority: high Component: Engine: Tucker
Version: Keywords: bud tucker bug intro
Cc: Game: Bud Tucker

Description

Pressing escape does not work and accessing the ScummVM menu doesn't not allow one to access the save/load features during the 10 minute intro. This means that the player has to sit through the 10 minute intro every single time that they start up the game!

This is an exclusive bug to ScummVM 2.9.0. As per the only workaround that I've is to clear the mapping for "Escape" within the ScummVM keymapping settings.

Change History (5)

comment:1 by tag2015, 4 weeks ago

Summary: Unable to skip the 10 minute intro to Bud Tucker (2.9.0)TUCKER: Unable to skip the 10 minute intro to Bud Tucker (2.9.0)

comment:2 by eriktorbjorn, 4 weeks ago

Is this the correct fix? I haven't really looked at the keymapper stuff, but the main event loop went from checking EVENT_KEYDOWN to checking EVENT_CUSTOM_ENGINE_ACTION_START to detect the Esc key.

diff --git a/engines/tucker/sequences.cpp b/engines/tucker/sequences.cpp
index 44850c04945..ef68040f617 100644
--- a/engines/tucker/sequences.cpp
+++ b/engines/tucker/sequences.cpp
@@ -578,8 +578,8 @@ void AnimationSequencePlayer::syncTime() {
                Common::Event ev;
                while (_event->pollEvent(ev)) {
                        switch (ev.type) {
-                       case Common::EVENT_KEYDOWN:
-                               if (ev.kbd.keycode == Common::KEYCODE_ESCAPE) {
+                       case Common::EVENT_CUSTOM_ENGINE_ACTION_START:
+                               if (ev.customType == kActionEscape) {
                                        _seqNum = 1;
                                }
                                break;

comment:3 by Filippos Karapetis <bluegr@…>, 2 weeks ago

In d173cce7:

TUCKER: Fix skipping cutscenes when the Esc key is mapped - bug #15707

Thanks to @eriktorbjorn for finding the issue. A regression from 783dfa8bdff5745a5929b3ec85ce91f679aed61c

comment:4 by bluegr, 2 weeks ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

Thanks! Fixed

comment:5 by Filippos Karapetis <bluegr@…>, 5 days ago

In 40a761cb:

TUCKER: Fix skipping cutscenes when the Esc key is mapped - bug #15707

Thanks to @eriktorbjorn for finding the issue. A regression from 783dfa8bdff5745a5929b3ec85ce91f679aed61c

Note: See TracTickets for help on using tickets.