Opened 8 weeks ago

Closed 8 weeks ago

#15701 closed defect (fixed)

SCI: LSL1VGA: Casino door semi-soft-lock

Reported by: ElTipejoLoco Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: original
Cc: Game: Leisure Suit Larry 1

Description

ScummVM 2.9.0 (Dec 8 2024 19:29:30)
Using SDL backend with SDL 2.0.14
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 FluidSynth Theora VPX AAC A/52 FreeType2 FriBiDi JPEG PNG GIF taskbar TTS cloud (servers, local) ENet SDL2 TinyGL OpenGL (with shaders)

In the screen in front of the casino's entrance, clicking the walk icon on the automatic doors from certain angles appears to cause the player to become stuck and unable to move, without loading the screen for the casino's interior. This would be a soft-lock if it weren't for the possibility of the black dog appearing in outdoor areas and approaching the player and triggering an animation that will reopen the doors and return control to the player.

  1. Position Larry right of the automatic doors (most easily achieved when entering from the Wedding Chapel outdoor screen).
  2. Use the Walk cursor to have Larry walk into the automatic doors; the cursor's feet should be at least above the bottom-most pixels of the doors.
  3. After Larry's walked into them, the doors should close and you should be able to suddenly see Larry's feet peeking out from their bottom despite his sprite probably moving further into the doors. The cursor should change into the wrist-watch loading icon, and all the top menu's icons, save for the Settings and Help ones, should become locked- but the casino interior screen will not load. The player will have to wait for the black dog to appear and trigger an animation to regain control.

Language: English
Version: Steam

Attachments (3)

lsl1sci.002 (34.7 KB ) - added by ElTipejoLoco 8 weeks ago.
Save file in a position that should trigger the bug before attempting walking into casino doors.
lsl1sci.003 (35.4 KB ) - added by ElTipejoLoco 8 weeks ago.
Save file where the player has already become stuck and must wait for the black dog to return control to them.
LSL1VGAWalkCursorPosition.png (36.2 KB ) - added by ElTipejoLoco 8 weeks ago.
Requested screenshot of a position that will trigger the bug.

Download all attachments as: .zip

Change History (8)

by ElTipejoLoco, 8 weeks ago

Attachment: lsl1sci.002 added

Save file in a position that should trigger the bug before attempting walking into casino doors.

by ElTipejoLoco, 8 weeks ago

Attachment: lsl1sci.003 added

Save file where the player has already become stuck and must wait for the black dog to return control to them.

comment:1 by sluicebox, 8 weeks ago

Hello! Thank you for reporting this. Can you attach a screenshot with the walk cursor on the spot that triggers the lockup from your save? I've tried quite a few times and haven't gotten it yet.

You've got the speed slider set low, are you getting the same result if you set it to high?

by ElTipejoLoco, 8 weeks ago

Requested screenshot of a position that will trigger the bug.

in reply to:  1 comment:2 by ElTipejoLoco, 8 weeks ago

Replying to sluicebox:

Hello! Thank you for reporting this. Can you attach a screenshot with the walk cursor on the spot that triggers the lockup from your save? I've tried quite a few times and haven't gotten it yet.

You've got the speed slider set low, are you getting the same result if you set it to high?

I've attached a screenshot that shows a position that will trigger the bug. Clicking above it should also display it. I noticed that there are some positions near the bottom of the door that won't, so I guess I overestimated the area when I described "any pixel above the doors' bottom."

Requested screenshot of a position that will trigger the bug.

Raising the speed slider from its default position and clicking around the same areas will sometimes trigger it and sometimes not: at its highest setting Larry will come into contact with the doors before they fully open, ultimately stopping his movement from reaching the destination where the player clicked (and therefore also not triggering the bug), and at some higher settings Larry will manage to reach what I assume is the actual loading part of the walking plane before the doors close and his sprite is strangely reset.

comment:3 by sluicebox, 8 weeks ago

Thank you! Reproduced on the first try.

comment:4 by sluicebox <22204938+sluicebox@…>, 8 weeks ago

In 995da763:

SCI: Fix LSL1 lockup when casino doors close

Fixes bug #15701

comment:5 by sluicebox, 8 weeks ago

Keywords: original added; LSL1VGA removed
Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Fixed in: 995da76327da9652380549b948f20bbe5591854c

This fix will appear in our next daily build of the master branch: https://buildbot.scummvm.org/#/dailybuilds

This is a script bug; it occurs in all versions of the original game.

The patch should fix everything except the save where you're already stuck behind the door. Thanks again for reporting!

Note: See TracTickets for help on using tickets.