SCI: Phantasmagoria can delete current save during chapter 7 in some cases

[neuromancer]

To reproduce, try the following:

1. Start a new game, but directly from the last chapter.
2. As soon as the chapter starts, save the game. If you quit the game and re-start, you can check that the save game is actually there.
3. Load the saved game and go directly to see Don upstairs.
4. You will start a sequence where you need to do a sequence of actions to survive. Just wait for the timeout (or do something wrong) and the player will die.
5. When asking if you want to keep playing, select no. The game will warn you that you will need to start the sequence again next time. Ignore that warning.
6. You will return to the main menu and your saved game is gone forever.

[neuromancer]

This can be reproduce in the latest revision (​https://github.com/scummvm/scummvm/commit/7f64ddfbb1a04f197a2355872d8c326c0c33543b)

[sluicebox]

Before we get to deep into this, how familiar are you with how this game treats chapter 7 saves? They're entirely separate and in a different format than the other chapters, and you have to access them from a different section of the main menu. It basically does a one-way migration when you get to chapter 7. And in your case, you aren't starting with a real save, you're jumping straight to it. I recall that the game manual goes into details about this.

I did a lot work on chapter 7 bugs years ago, and what I came away with was that the original behavior is very confusing. I have to ask that you please verify the behavior you're seeing against the original game and specify the exact discrepancy, preferably with screenshots.

[neuromancer]

Some answers to you questions:

• I checked the manual and indeed there is a mention to the chapter 7. Accessing the "watch movie" section showed some of my "deleted" save games, but not all of them. So I believe the bug is still there. Checking my scummvm save directory shows this:

phantasmagoria-chasedun.0 
phantasmagoria-chasedun.1 
phantasmagoria-phantsg.0  
phantasmagoria-phantsg.1  
phantasmagoria-phantsg.dir
phantasmagoria-pref.dat   
phantasmagoria-xyz.tmp    

• I originally discovered this after starting the game from chapter 1, so the original savegame deleted was one that started from chapter 1. After that, I decided to start trying to reproduce the bug. However, it seems that my instructions to reproduce the issue are no longer valid, since the savegame produced by this instructions is still available in the "watch movie" section.

• I never played the original game, just the ScummVM reimplementation.

I know that all these details are vague. Feel free to close the issue if you cannot reproduce it on your end.