[2.9.0] FTBFS - dlcmanager: error: 'Error' in namespace 'Common' does not name a type

[tgurr]

Build for 2.9.0 fails with:

[...]
mkdir -p backends/dlc/.deps
x86_64-pc-linux-gnu-c++ -MMD -MF "backends/dlc/.deps/dlcmanager.d" -MQ "backends/dlc/dlcmanager.o" -MP -Wall -march=native -O2 -pipe -march=native -O2 -pipe -Wshadow -W -Wno-unused-parameter -Wno-empty-body -fno-operator-names -std=c++11 -pedantic -Wno-address-of-packed-member -O2 -Wuninitialized -fPIC -I/usr/x86_64-pc-linux-gnu/include/freetype2 -I/usr/x86_64-pc-linux-gnu/include/libpng16 -I/usr/x86_64-pc-linux-gnu/include/harfbuzz -I/usr/x86_64-pc-linux-gnu/include/glib-2.0 -I/usr/x86_64-pc-linux-gnu/lib/glib-2.0/include -Wno-long-long -Wno-multichar -Wno-unknown-pragmas -Wno-reorder -Wpointer-arith -Wcast-qual -Wnon-virtual-dtor -Wwrite-strings -fno-exceptions -fcheck-new -DHAVE_CONFIG_H -DRELEASE_BUILD -DSDL_BACKEND -DUSE_SDL2 -DHAS_GETADDRINFO -DHAS_GETNAMEINFO -DHAS_GETHOSTBYADDR_R -DHAS_GETHOSTBYNAME_R -DHAS_POLL -DHAS_FCNTL -DHAS_INET_PTON -DHAS_INET_NTOP -DHAS_MSGHDR_FLAGS -DHAS_SOCKLEN_T -DPOSIX -DHAS_POSIX_SPAWN -DHAS_FSEEKO_OFFT_64 -DDATA_PATH=\"/usr/share/scummvm\" -DPLUGIN_DIRECTORY=\"/usr/x86_64-pc-linux-gnu/lib/scummvm\" -DENABLE_SCUMM=DYNAMIC_PLUGIN -DENABLE_SCUMM_7_8 -DENABLE_HE -DENABLE_ACCESS=DYNAMIC_PLUGIN -DENABLE_ADL=DYNAMIC_PLUGIN -DENABLE_AGI=DYNAMIC_PLUGIN -DENABLE_AGOS=DYNAMIC_PLUGIN -DENABLE_AGOS2 -DENABLE_ASYLUM=DYNAMIC_PLUGIN -DENABLE_AVALANCHE=DYNAMIC_PLUGIN -DENABLE_BAGEL=DYNAMIC_PLUGIN -DENABLE_BBVS=DYNAMIC_PLUGIN -DENABLE_BLADERUNNER=DYNAMIC_PLUGIN -DENABLE_BURIED=DYNAMIC_PLUGIN -DENABLE_CGE=DYNAMIC_PLUGIN -DENABLE_CGE2=DYNAMIC_PLUGIN -DENABLE_CHAMBER=DYNAMIC_PLUGIN -DENABLE_CHEWY=DYNAMIC_PLUGIN -DENABLE_CINE=DYNAMIC_PLUGIN -DENABLE_COMPOSER=DYNAMIC_PLUGIN -DENABLE_CRAB=DYNAMIC_PLUGIN -DENABLE_CRUISE=DYNAMIC_PLUGIN -DENABLE_CRYO=DYNAMIC_PLUGIN -DENABLE_CRYOMNI3D=DYNAMIC_PLUGIN -DENABLE_VERSAILLES -DENABLE_DARKSEED=DYNAMIC_PLUGIN -DENABLE_DGDS=DYNAMIC_PLUGIN -DENABLE_DIRECTOR=DYNAMIC_PLUGIN -DENABLE_DM=DYNAMIC_PLUGIN -DENABLE_DRACI=DYNAMIC_PLUGIN -DENABLE_DRAGONS=DYNAMIC_PLUGIN -DENABLE_DRASCULA=DYNAMIC_PLUGIN -DENABLE_DREAMWEB=DYNAMIC_PLUGIN -DENABLE_EFH=DYNAMIC_PLUGIN -DENABLE_FREESCAPE=DYNAMIC_PLUGIN -DENABLE_GLK=DYNAMIC_PLUGIN -DENABLE_GNAP=DYNAMIC_PLUGIN -DENABLE_GOB=DYNAMIC_PLUGIN -DENABLE_GRIFFON=DYNAMIC_PLUGIN -DENABLE_GRIM=DYNAMIC_PLUGIN -DENABLE_MONKEY4 -DENABLE_GROOVIE=DYNAMIC_PLUGIN -DENABLE_GROOVIE2 -DENABLE_HADESCH=DYNAMIC_PLUGIN -DENABLE_HDB=DYNAMIC_PLUGIN -DENABLE_HOPKINS=DYNAMIC_PLUGIN -DENABLE_HUGO=DYNAMIC_PLUGIN -DENABLE_HYPNO=DYNAMIC_PLUGIN -DENABLE_ICB=DYNAMIC_PLUGIN -DENABLE_ILLUSIONS=DYNAMIC_PLUGIN -DENABLE_IMMORTAL=DYNAMIC_PLUGIN -DENABLE_KINGDOM=DYNAMIC_PLUGIN -DENABLE_KYRA=DYNAMIC_PLUGIN -DENABLE_LOL -DENABLE_EOB -DENABLE_LAB=DYNAMIC_PLUGIN -DENABLE_LASTEXPRESS=DYNAMIC_PLUGIN -DENABLE_LILLIPUT=DYNAMIC_PLUGIN -DENABLE_LURE=DYNAMIC_PLUGIN -DENABLE_M4=DYNAMIC_PLUGIN -DENABLE_MACVENTURE=DYNAMIC_PLUGIN -DENABLE_MADE=DYNAMIC_PLUGIN -DENABLE_MADS=DYNAMIC_PLUGIN -DENABLE_MADSV2 -DENABLE_MM=DYNAMIC_PLUGIN -DENABLE_MM1 -DENABLE_XEEN -DENABLE_MOHAWK=DYNAMIC_PLUGIN -DENABLE_CSTIME -DENABLE_MYST -DENABLE_MYSTME -DENABLE_RIVEN -DENABLE_MORTEVIELLE=DYNAMIC_PLUGIN -DENABLE_MTROPOLIS=DYNAMIC_PLUGIN -DENABLE_MUTATIONOFJB=DYNAMIC_PLUGIN -DENABLE_MYST3=DYNAMIC_PLUGIN -DENABLE_NANCY=DYNAMIC_PLUGIN -DENABLE_NEVERHOOD=DYNAMIC_PLUGIN -DENABLE_NGI=DYNAMIC_PLUGIN -DENABLE_PARALLACTION=DYNAMIC_PLUGIN -DENABLE_PEGASUS=DYNAMIC_PLUGIN -DENABLE_PETKA=DYNAMIC_PLUGIN -DENABLE_PINK=DYNAMIC_PLUGIN -DENABLE_PLAYGROUND3D=DYNAMIC_PLUGIN -DENABLE_PLUMBERS=DYNAMIC_PLUGIN -DENABLE_PRINCE=DYNAMIC_PLUGIN -DENABLE_PRIVATE=DYNAMIC_PLUGIN -DENABLE_QDENGINE=DYNAMIC_PLUGIN -DENABLE_QUEEN=DYNAMIC_PLUGIN -DENABLE_SAGA=DYNAMIC_PLUGIN -DENABLE_IHNM -DENABLE_SAGA2=DYNAMIC_PLUGIN -DENABLE_SCI=DYNAMIC_PLUGIN -DENABLE_SCI32 -DENABLE_SHERLOCK=DYNAMIC_PLUGIN -DENABLE_SKY=DYNAMIC_PLUGIN -DENABLE_SLUDGE=DYNAMIC_PLUGIN -DENABLE_STARK=DYNAMIC_PLUGIN -DENABLE_STARTREK=DYNAMIC_PLUGIN -DENABLE_SUPERNOVA=DYNAMIC_PLUGIN -DENABLE_SWORD1=DYNAMIC_PLUGIN -DENABLE_SWORD2=DYNAMIC_PLUGIN -DENABLE_SWORD25=DYNAMIC_PLUGIN -DENABLE_TEENAGENT=DYNAMIC_PLUGIN -DENABLE_TESTBED=DYNAMIC_PLUGIN -DENABLE_TETRAEDGE=DYNAMIC_PLUGIN -DENABLE_TINSEL=DYNAMIC_PLUGIN -DENABLE_TOLTECS=DYNAMIC_PLUGIN -DENABLE_TONY=DYNAMIC_PLUGIN -DENABLE_TOON=DYNAMIC_PLUGIN -DENABLE_TOUCHE=DYNAMIC_PLUGIN -DENABLE_TRECISION=DYNAMIC_PLUGIN -DENABLE_TSAGE=DYNAMIC_PLUGIN -DENABLE_TUCKER=DYNAMIC_PLUGIN -DENABLE_TWINE=DYNAMIC_PLUGIN -DENABLE_TWP=DYNAMIC_PLUGIN -DENABLE_ULTIMA=DYNAMIC_PLUGIN -DENABLE_ULTIMA1 -DENABLE_ULTIMA4 -DENABLE_ULTIMA6 -DENABLE_ULTIMA8 -DENABLE_VCRUISE=DYNAMIC_PLUGIN -DENABLE_VOYEUR=DYNAMIC_PLUGIN -DENABLE_WAGE=DYNAMIC_PLUGIN -DENABLE_WATCHMAKER=DYNAMIC_PLUGIN -DENABLE_WINTERMUTE=DYNAMIC_PLUGIN -DENABLE_FOXTAIL -DENABLE_HEROCRAFT -DENABLE_WME3D -DENABLE_ZVISION=DYNAMIC_PLUGIN -I. -I. -I./engines -I/usr/x86_64-pc-linux-gnu/include/SDL2 -D_REENTRANT -I/usr/include -I/usr/x86_64-pc-linux-gnu/include/SDL2 -D_REENTRANT    -I/usr/x86_64-pc-linux-gnu/include/libpng16     -I/usr/x86_64-pc-linux-gnu/include -c backends/dlc/dlcmanager.cpp -o backends/dlc/dlcmanager.o
In file included from backends/dlc/dlcmanager.cpp:26:
./backends/dlc/scummvmcloud.h:53:17: error: 'Error' in namespace 'Common' does not name a type
   53 |         Common::Error extractZip(const Common::Path &file, const Common::Path &destPath);
      |                 ^~~~~

Error:
  * In program cave perform install --hooks --managed-output --output-exclusivity with-others =games-adventure/scummvm-2.9.0:0::games --destination installed --x-of-y 1 of 1:
  * When installing 'games-adventure/scummvm-2.9.0:0::games':
  * When running an ebuild command on 'games-adventure/scummvm-2.9.0:0::games':
  * Install failed for 'games-adventure/scummvm-2.9.0:0::games' (paludis::ActionFailedError)

make: *** [Makefile.common:177: backends/dlc/dlcmanager.o] Error 1
[...]

$ gcc --version
gcc (GCC) 14.2.0

Complete build log is attached.

[lephilousophe]

The DLC feature is not supported and should not be enabled unless you know what you do.

Fixed in 0fe46dbebf4f89a6325f80316f189cb083589bd9.