Opened 7 days ago
Last modified 2 days ago
#15673 new defect
BACKENDS: PSP: Scumm/HE engine plugin crashes when adding or starting game
| Reported by: | rsn8887 | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | Port: PSP |
| Version: | Keywords: | HE crash | |
| Cc: | Game: |
Description
I omitted the HE engine on PSP 2.9.0 because the latest additions to the HE engine are causing a crash (reboot) on PSP when adding or starting a game. This bug is happening only on real hardware, not on the PPSSPP emulator.
Change History (2)
comment:2 by , 2 days ago
| Summary: | HE engine plugin crashes on PSP when adding or starting game → BACKENDS: PSP: Scumm/HE engine plugin crashes when adding or starting game |
|---|
Note:
See TracTickets
for help on using tickets.
Using git bisect and many tests on my PSP, I narrowed the problem down to this gigantic, recent, HE commit:
https://github.com/scummvm/scummvm/commit/8b5ad52d88be4f8a274badff88049a97dd4beffc
The fact that this is such a large commit makes it very hard to debug. We think the problem is due to static variable usage within the HE plugin. The reason we think static vars might be the problem is that a previous commit was causing a similar problem, this one:
https://github.com/scummvm/scummvm/commit/b2a158b7c48cdcbd2412eedf1cea69e52ab7ccfc
The bug in the above commit was caused by four static variable declarations in map_spiff.cpp. Changing those to const fixed it temporarily, until the bug was then re-introduced by the first mentioned massive commit.