SCI: kq4sci-amiga skips title screen

[prietveld]

The Amiga version of King's Quest IV (1.023) skips the title screen after clicking or entering 'Yes' to the question 'Is this your first time playing [...]?' and goes directly to the credits. This on ScummVM 2.9.0 x86-64.

Based on several let's play-video's I believe this should not happen and the title screen should remain visible longer, with music playing in the background.

[sluicebox]

Hello! Thank you for reporting, I have confirmed that this bug occurs in the latest daily build.

After selecting "Yes", the game should remain on the title screen and play music instead of jumping to credits. That is how the DOS version behaves, both in ScummVM and the original interpreter, and how the Amiga version should behave according to this play through: ​https://www.youtube.com/watch?v=HKwgixkqSzA

[sluicebox <22204938+sluicebox@…>]

In 8144e3e6:

SCI: Fix KQ4 Amiga sound signals

Fixes bug #15660

Limits the workaround for KQ4 broken signals to just the introduction.
We now know that it's the only sound that requires this, and that the
Amiga version added signal 127 to almost every sound.

See: 08b9c26752174a247d5aa06da7b498c818def1a7

Thanks to @athrxx for locating behavior in Amiga driver disassembly
Thanks to @prietveld for reporting

[sluicebox]

Fixed in: 8144e3e69d3cc5ab5f3ea46309fe192849c7d152

This will appear in the next daily build.

This was a regression I introduced in 2023 with a workaround for KQ4's broken sound signals that cause the end of the introduction to wait forever instead of starting the game. I did not know that Amiga had added these same signals to almost every sound, so that caused the bannerSound object to signal unexpectedly early.

Thanks again for reporting!