GUI: Load button is disabled even when saves are present

[ctoroman]

ScummVM 2.10.0git11945-g7186f8e6a5b (Jan 1 2025 04:39:27)
OS: Windows 10

This happened after commits:
​https://github.com/scummvm/scummvm/commit/979a17edc420ec945be284398271a292deda6624
​https://github.com/scummvm/scummvm/commit/a86405389a405616e261fee21ba2b5e29b1a5851

(list_after_commit.jpg)

After the cancellation of these fixes, everything works fine.
(list_before_commit_1.jpg and list_before_commit_2.jpg)

[digitall]

The screenshots provided show this occurring with Legend of Kyrandia CD/DOS/Russian. This may be an issue with the KYRA engine APIs for save/load state. Will try replicating...

[ctoroman]

Legend of Kyrandia is just an example. The problem is also with Gobliiins 5, Full Throttle...

[criezy]

Note that the code causing this issue was reverted on January 2 as more issues were found (related to performances). I may revisit this feature, so this bug report is still useful as a reminder that there was an issue with the original code and to pay special care to this. But since the issue should no longer present in current code I think we can close this?

[ctoroman]

If the problem is solved, then we can close this, of course. Thanks)

[digitall]

@criezy: As this is "fixed" by removal of the code in the current master and was not included in the v2.9.0 release, am going to close this bug as fixed... though as you said, future reference if the code removed is restored in future with fixes.

@ctoroman: Thanks. Please reopen this bug if/when this occurs again and/or the code is re-added and this re-occurs.