Warnings in status window when adding any game

[prietveld]

When adding any new game to ScummVM 2.9.0 via the 'Add Game...' function the status windows shows the following warnings, including a seemingly unrelated one about toltecs. I tried adding Grim Fandango, The Dig, Discworld 2 and others and all show these exact same warnings. 2.8.1 had no warnings at all. This is with the x86-64 build. There seem to be no adverse effects to this so far.

WARNING: DebugManager::addDebugChannels(): No debug channels were added, list is empty!
WARNING: DebugManager::addDebugChannels(): No debug channels were added, list is empty!
WARNING: Path component detected in entry for 'toltecs:toltecs' but no kADFlagMatchFullPaths is set!

[digitall]

Replicated the warnings with the latest git master using detection of an AGS game.

The second warning is caused by an entry in the Toltecs engine detection tables:
WARNING: Path component detected in entry for 'toltecs:toltecs' but no kADFlagMatchFullPaths is set!

The entry is:

{

3 Skulls of the Toltecs English Demo version (original file layout)
{

"toltecs",
"Demo",
AD_ENTRY1s("english.pdi/WESTERN", "53a0abd1c0bc5cad8ba18f0e56877705", 46241833),
Common::EN_ANY,
Common::kPlatformDOS,
ADGF_DEMO,
GUIO1(GAMEOPTION_ORIGINAL_SAVELOAD)

},

},

[digitall]

The "/" path separator in the filename for the detection entry is causing this.

[digitall]

This was caused by the fix for this bug: https://bugs.scummvm.org/ticket/13231

[digitall]

This warning should be fixed by ​https://github.com/scummvm/scummvm/commit/ad10b0edaba2ec03001cc68f14e74b1eb3317fbb

[digitall]

The second warning of "WARNING: DebugManager::addDebugChannels(): No debug channels were added, list is empty!" is emitted by the detection code of the PRINCE engine. The debug channels were not setup as expected. An enumerated type starts from 0 unless otherwise defined to a value and this was not done for PRINCE. The debug code uses the value 0 to indicate the end of the structure and thus did not add any debug channels for this engine. This should be fixed by ​https://github.com/scummvm/scummvm/commit/1f01b10618023e3a810ab20b42b22eb9e4be864f

[digitall]

In 0438c92:

BAGEL: Remove Unused Debug Flag Related Code

This was causing a "No debug channels were added, list is empty!"
warning to be emitted on the console during detection due to the empty
debugflag list. Easier to remove this unused code as it can be restored
if debugflags are implemented for this engine in future.

This resolves bug #15616 "Warnings in status window when adding any game".

[digitall]

The first warning was due to a empty debugflag list being declared by the BAGEL engine. This has now been resolved.

Have tested and this fixes all the observed warnings. Closing as fixed.