SCI: KQ6CD - HD Portraits out of boundaries drawn remain visible

[LaZar00]

Game Version : KQ6 CD Talkie english version (GOG release)

ScummVM version : Latest daily build 0x1d5e260c

OS : Windows 11 x64

Hi. Not sure if this is considered a bug, but I tried different options, changing driver, among other things, and always seems to happen.
When you reach "Beauty" room, the stepmother is shouting at Beauty. The stepmother has not portrait, but the last line, when Beauty talks, it has portrait (in HD version, the low resolution version has NOT portrait and this does not happens).

Then, part of that portrait remains drawn outside the boundaries of the picture/room/drawing. If you go up with mouse to see the Icon Bar, it is cleaned tough. But it seems to be some strange behaviour.

Besides, I checked other HD portraits, like Graham or Ali or Pawn Shop owner, and they seem to work well (and they are drawn also out of boundaries).

I also saw some videos in youtube of this part, in hd graphics. and the drawing seems to be correct. No portrait outside boudaries. Maybe a regression?

I leave a video to see what I mean.

[LaZar00]

After more testing, this overlay in HD Enhanced mode of KQ6CD is happening also with the own windows. For example, if we look at some item in inventory window, the text overlays the icons, and after that they are not correctly seen - didn't refresh (you need to have 2 lines of icons and look at some item with long description like nightingale). I leave another video.

PD2: And more testing. I tried this in the original scummvm 2.0.0 version that comes with GOG release. In this version seems to work well, the portrait and the icons overlay.

PD3: A third sample would be the creature you get hanging from the tree (the one you give the WHERE sentence). When you click that creature in inventory with hand icon, the message that appears draws incorrectly the background icons (bad refresh). With low resolution this does not happens.

PD4: More testing. In Beast Island, when Alex has to use the iceberg in the pond. You can hear the pond bubbles. Use the iceberg, and then you hear the dialogue. But this dialogue does not closes automatically, and the pond bubbles sound stops. This is very odd. This happens when checked "prefer digital sfx". This is not happening in 2.0.0 version of GOG release. Not sure if this has to do with window overlay I have been reporting here.

[athrxx]

Do these glitches only occur in mixed speech/text mode?

In the ticket you're saying "i tried different options, changing driver, among other things, and always seems to happen". But the attached videos all seem to be from mixed speech/text mode.

This is probably a regression. The mixed mode was not supported in the original game and does certain things that have to be worked around (like drawing portraits outside the view port boundaries). We did have a different workaround for the out-of-bounds-drawing which is no longer usable with the changed graphics code. The one we have now apparently does not catch all cases...

The window overlay glitch is a bit more annoying. The original interpreter does have specific code to restore hires graphics after closing a window. Which the original probably never needed, since the devs ditched the mixed speech/text mode, anyway. Implementing that restoring code might fix that issue.

No idea about no. 4, but that also seems to be specific to the mixed speech/text mode.

[LaZar00]

With driver I mean graphic driver, OpenGL or by default. But yes, I'm using mixed mode.

In any case, this is happening with mixed mode (or Dual), or only using Voices for example. I tested it just now.

Have in mind that ALL this (all 4 points) is not happening with ScummVM 2.0.0 (which supports Dual mode).

I thought about hires icons and portraits, and I assume original interpreter is working in a different way as ScummVM does when it has to process lowres and hires graphics. But you have more knowledge than me in this.

Maybe the 4 point could be related to this processing also (hires/lowres), and the sound/music or whatever is not refreshed either. Have in mind that you see the Portrait in hires while hearing/seeing the text/voice and before the sound stops. The thruth is that this 4 point happens also with lowres graphics ONLY.

BTW, the possibility to use text+speech is amazing. Congratulations.

PD: I just tested KQ6 lowres in DosBox. The point 4 of the glitch of the sound also happens. So, I would say that this is the normal behaviour (at least with digital, not sure with MT32) for this issue. I think we can forget this. I can not test hires for the portraits or icons, I should install win 3.1 and I have not it installed.

[sluicebox]

Yes, this only occurs in our text+speech mode that does not exist in the original. Normally, the portrait only appears in speech mode, and it appears within the picture boundaries.

Attached is a save game a few seconds before this occurs.

[LaZar00]

The odd thing is that the other portraits appear also outside boundaries but they don't have this glitch. Until now this is the only one doing this. As I said, this portrait does not appears in lowres mode. Maybe the script of the portrait 895/8951 (Beauty.sc) should add it or has something wrong, who knows.

Also, there is the hires icons glitch when showing, for example, a description of an item that overlays the inventory window.

PD2: More comparision. This is about point 4. When using LOOK or HAND icons in the pond with boiling water (minute 1:05:58):

​https://www.youtube.com/watch?v=3PNx6P81DbI&t=3958s

You can see the sound of boiling water remains even when the Narrator talks -looks- (or Alex touches the pond). I don't know the method this user plays KQ6CD (old scummvm, dosbox with w3.1, w95...), but this seems to me a better method than the one that now plays this sequence of the pond, which stops totally the pond boiling sound. FYI: Using MT32 emulator for the sound (and not digital sound) continues playing also.

[LaZar00]

I leave here a save for testing the sound of the pond with bubbles (if you decide finally that this must be looked at). The save is from GOG version (using 2.9.0 daily build).

If you have any issues let me know. And maybe this 4 point strange behaviour would be interesting to split into a different issue than this one. You must go one screen north and there is the pond. Here it is also the "participle", that launches de window over the inventory window. So, you can check it if you want.

PD: When disabling "Prefer Digital Sound Effects" option, it seems NOT to happen. So, using FM or MT32 sounds, works as expected. Having enabled "Prefer Digital Sound Effects" and playing ONLY with "TEXT" subtitles, seems NOT to happen either. It only happens when having enabled "Prefer Digital Sound Effects" and "VOICES" or "DUAL" subtitles. So, I understand, that somehow, the voices (original) part is stopping the digital sound somehow. But maybe this is correct from the point of view of the original interpreter.

[LaZar00]

Finally I decided to open the issue #15606 with the 4 point. I think this issue is different from the first three points of this ticket.

I tested the commits of this ticket and they work like a charm. Excellent job. :)

I think this issue can be closed and continue the last point in the new ticket.

Regards.

[LaZar00]

Ok, I found an added issue regarding the bug of the inventory one with hires icons.

The issue appears when we have more than one inventory window (this is the scroll arrows for going up and down in inventory), and in the second inventory, we click in some item with description. The redraw of the hires icons is shown incorrect (maybe is corrupted?) in screen. See video 18:48:43.03, near the end.

I add also a save kq6-cd.012.

[athrxx]

Thanks! Fortunately, this just seems to be a mistake I made in my last commit (as I am still waiting for something unfixable to happen so that I finally understand why Sierra gave up on that speech+text mode). I have pushed a fix to the repo.

[LaZar00]

Will try again when commited. Thanks a lot for your effort. I can understand the difficulty of this Dual mode, and now is Dual mode + High res mode. xD

I will try to report all the things I can while testing the localization to spanish of KQ6CD. The lowres Dual version works flawless graphically (with minor sound issues - point 4). I finished the test run days ago.

With the highres, well... we will see...

[LaZar00]

I tried the fix for inventory with more than one inventory page. Now works as expected (or at least I can not reproduce the issue). Good work!

[athrxx]

Thanks! I think we can close this one, since the remaining part has been moved to a different ticket.