FREESCAPE: Flat objects on the floor flicker in Total Eclipse (DOS)

[NigeNigeNige]

In the room HORAKHTY-H (and possibly others), there are some flat footsteps that should be at the same level as the floor. These flicker when the mouse is moved and show as shaded polygons when they should be stable and solid black.

[NigeNigeNige]

Example of problem

[neuromancer]

Good catch!, I can confirm this issue. Please let me know any other objects that have a similar glitch while I investigate this one.

[neuromancer]

It seems that certain size information used by the renderer (but not in the original implementation) is missing in the game data (!). This is a simple workaround:

diff --git a/engines/freescape/games/eclipse/dos.cpp b/engines/freescape/games/eclipse/dos.cpp
index f9aefea0fa0..24d70ba87da 100644
--- a/engines/freescape/games/eclipse/dos.cpp
+++ b/engines/freescape/games/eclipse/dos.cpp
@@ -141,6 +141,19 @@ void EclipseEngine::loadAssetsDOSFullGame() {
                swapPalette(_startArea);
        } else
                error("Invalid or unsupported render mode %s for Total Eclipse", Common::getRenderModeDescription(_renderMode));
+
+       Object *obj = nullptr;
+       obj = _areaMap[9]->objectWithID(7);
+       assert(obj);
+       obj->_size = Math::Vector3d(3, 0, 2);
+
+       obj = _areaMap[9]->objectWithID(8);
+       assert(obj);
+       obj->_size = Math::Vector3d(3, 0, 2);
+
+       obj = _areaMap[9]->objectWithID(9);
+       assert(obj);
+       obj->_size = Math::Vector3d(3, 0, 2);
 }
 
 void EclipseEngine::drawDOSUI(Graphics::Surface *surface) {

I will investigate if the same is happening in other releases.

[neuromancer]

Fixed here: ​https://github.com/scummvm/scummvm/commit/b7ddba286018ca726c012d6b83882a637ba07937

Please test using daily builds (or compile it on your own) if possible.

[NigeNigeNige]

Testing with build fa0bb2d3 - same issue with the mummy's eye in HORAKHTY-G. Also thanks for responding quickly!

[neuromancer]

I think this commit should improve it: ​https://github.com/scummvm/scummvm/commit/136886c4fe810d506f9c7ecd7ed13008336bba23

Please test it, if possible. Thanks!

[NigeNigeNige]

Testing with 6ec64ff3, the footsteps are fixed. The mummy now has a very small pixel-width? dot for the eye, which is barely visible. The original was also a pixel wide but the pixels were bigger back then.

[neuromancer]

This was already fixed