Opened 3 months ago

Closed 3 months ago

#15557 closed defect (fixed)

Police Quest 2: incorrect key listing for "Fire Gun" in upper menu

Reported by: ATMcashpoint Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords:
Cc: Game: Police Quest 2

Description

In Police Quest 2 (English, DOS, version 1.002.011, played in the ScummVM Windows 64-bit daily build for December 5, 2024, on a Windows 11 PC), at any time during gameplay, if you use the cursor to bring up the "Action" menu at the top of the screen, among the options listed is "Fire Gun", which is said to be assigned to the "F0" key.

Obviously it should say F10 instead, since that's the key the game expects.

This error is not present when playing the game on original hardware, so somehow ScummVM is messing up the key listings in the upper menu.

Change History (3)

comment:1 by sluicebox <22204938+sluicebox@…>, 3 months ago

In 068fe4b8:

SCI: Fix Menu display of F10 keyboard shortcut

Fixes bug #15557

Thanks to @ATMcashpoint for reporting this

comment:2 by sluicebox <22204938+sluicebox@…>, 3 months ago

In f604f18:

SCI: Fix Menu display of F10 keyboard shortcut

Fixes bug #15557

Thanks to @ATMcashpoint for reporting this

comment:3 by sluicebox, 3 months ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Great catch! And with one day to spare before the release deadline...

This bug has been there since the menu code was written in 2009, but there aren't many F10 menus. Scanning my sci-scripts repo shows only this one, the About menu in Jones in the fast lane, the KQ4 "overtime nosleep" debug menu, and Macintosh hoyle1 and holyle2.

Thanks for reporting this!

Note: See TracTickets for help on using tickets.