Opened 4 months ago

Last modified 4 months ago

#15555 new defect

KYRA: KYRA1 - misaligned options text and buttons

Reported by: Thelypody Owned by:
Priority: normal Component: Engine: Kyra
Version: Keywords:
Cc: Game: Kyrandia 1

Description

ScummVM version: ScummVM 2.9.0pre11155-g52c98292fbf (Dec 3 2024 13:58:38)
OS: Windows 11 Enterprise 23H2 22631.4460
Game: kyra1-cd

Running the English DOS CD version of Legend of Kyrandia: Book One. Going to options and selecting Game Controls leads to a menu with suspiciously narrow buttons, with "Voice & Text" label visibly spilling outside of its intended area. Choosing "Text only" option creates a new menu item which slightly overlaps with "Main menu" button.

Comparing ScummVM screenshot to a screenshot of the game running in 86box emulator shows that the text and buttons is aligned much closer to the window center and the "Main menu" button is a bit higher in ScummVM.

Attachments (2)

scummvm-kyra1-cd-00000.png (32.5 KB ) - added by Thelypody 4 months ago.
Emulated screenshot.png (29.0 KB ) - added by Thelypody 4 months ago.

Download all attachments as: .zip

Change History (3)

by Thelypody, 4 months ago

Attachment: scummvm-kyra1-cd-00000.png added

by Thelypody, 4 months ago

Attachment: Emulated screenshot.png added

comment:1 by athrxx, 4 months ago

Thanks for your report.

This is a known regression from a pull request.
https://github.com/scummvm/scummvm/pull/4798

I have reverted the "improvements", since they also break many other gui elements. Some examples have been posted as screenshots on the pr page.

The dialogs should now no longer be misaligned, but they definitely don't have the dimensions from the original interpreters. It is more like a "one size fits all" dialog, suitable for all language and platform versions.

Maybe I (or anyone) finds the time some day to extract the coordinates for all these elements from the executable and stuff them into our static resource file, so that the dialogs really will have the original look.

Note: See TracTickets for help on using tickets.