Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#15520 closed defect (fixed)

SCUMM: MACGUI: Disabling Original GUI in mid-playthrough causes black square cursor

Reported by: eriktorbjorn Owned by: bluegr
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game:

Description

This applies to the Macintosh versions of Monkey Island 1, Monkey Island 2, and Indiana Jones and the Fate of Atlantis.

Steps to reproduce:

  • Start the game with the "original GUI" (Mac menus etc.) enabled.
  • Save the game, then quit.
  • Disable the original GUI.
  • Start the game, then load the previous savegame.

Instead of a crosshair mouse cursor, there's now just a black square.

Attachments (2)

scummvm-atlantis-mac-00004.png (47.2 KB ) - added by eriktorbjorn 3 months ago.
scummvm-monkey2-mac-00012.png (77.9 KB ) - added by eriktorbjorn 3 months ago.

Download all attachments as: .zip

Change History (9)

comment:1 by bluegr, 3 months ago

The black cursor is caused when overriding the default cursor's palette.

I've tried this scenario with the following:

  • Monkey Island 1 - bug exists
  • Monkey Island 2 - works fine
  • Indy 3 - works fine
  • Indy 4 - works fine
  • Loom - works fine

So it's only Monkey Island 1 that has this issue, because it calls _windowManager->replaceCursor() from within MacV5Gui::setupCursor() with a predefined cursor, which also sets its palette.

Monkey 2, Loom, Indy 3 and Indy 4 use a custom cursor, without overriding the default cursor's palette.

Last edited 3 months ago by bluegr (previous) (diff)

comment:2 by Filippos Karapetis <bluegr@…>, 3 months ago

In dc978759:

SCUMM: Fix MI1 Mac cursor when loading certain saved games - bug #15520

We need to reset Mac cursors if the original GUI isn't enabled for games
which replace cursors that override the default cursor palette.

comment:3 by Filippos Karapetis <bluegr@…>, 3 months ago

In d3f79b86:

SCUMM: Fix MI1 Mac cursor when loading certain saved games - bug #15520

We need to reset Mac cursors if the original GUI isn't enabled for games
which replace cursors that override the default cursor palette.

comment:4 by bluegr, 3 months ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

by eriktorbjorn, 3 months ago

by eriktorbjorn, 3 months ago

comment:5 by eriktorbjorn, 3 months ago

It still happens for me in both Fate of Atlantis ...


... and in Monkey Island 2.


comment:6 by Torbjörn Andersson <eriktorbjorn@…>, 3 months ago

In d30acbc6:

SCUMM: Extend the fix for bug #15520 to cover all v5 Mac games

The previous change fixed the problem for me in MI1, but I would still
see it in MI2 and Fate of Atlantis.

comment:7 by Torbjörn Andersson <eriktorbjorn@…>, 3 months ago

In 97157390:

SCUMM: Extend the fix for bug #15520 to cover all v5 Mac games

The previous change fixed the problem for me in MI1, but I would still
see it in MI2 and Fate of Atlantis.

Note: See TracTickets for help on using tickets.