TWINE: LBA - Using the Holomap while Twinsen is walking may cause glitch

[antoniou79]

This was tested with ScummVM 2.9.0git (recent build from Master HEAD).

While walking press Shift (to open your inventory) and choose the hologlobe.

On the holomap, use the numpad keys (8,4,6,2) to manually rotate the sphere. Rotate the sphere for a bit.

(Using the plain arrow keys will trigger an auto-rotation to a known location on the holomap; I am unsure if this can also cause the same glitch)

After rotating the sphere press Esc.

At this point I've had a few potential glitches:

• Twinsen may glide across the floor for a bit
• Twinsen may teleport forward or upwards. (I've had him teleport in a "void" area of the map, where he subsequently fell (endlessly?) and I've also had him teleport on a pillar (in the library) where he normally cannot go.
• Other NPC characters may appear to glide too after using the holomap, but this may not be related to this particular issue.

[antoniou79]

This also happens in ScummVM 2.8.1 (Windows 10 x64)

[mgerhardy]

This is most likely related to some timer lock being missing in the holomap code

[mgerhardy]

see issue: https://bugs.scummvm.org/ticket/14808

[mgerhardy]

In 6bd71381:

TWINE: fixed a few freezeTime related issues as given in #15400

https://bugs.scummvm.org/ticket/15400

redrawEngineActions does its own timer freeze again and we might lose them by
using ScopedEngineFreeze

[mgerhardy]

a few timer freeze (glide) related issues were fixed in 6bd713813204c879097e3d8754c727b4b7505494

[mgerhardy]

Looks like this is fixed for me now - I can't reproduce this anymore.

[antoniou79]

Replying to mgerhardy:

Looks like this is fixed for me now - I can't reproduce this anymore.

I can confirm this. It seems fixed to me too, after a few attempts to reproduce.