TWINE: LBA: Asking about pirate recipes results in stuck dialogue

[antoniou79]

This is tested on Windows 10, on ScummVM 2.9.0git (from recent master HEAD) on the GOG version of the game.

I am attaching a saved game. You start at the entrance of the library and you have to go to the elephant NPC that sits and reads a book outside the projection/theater room. He's the only one who will respond to Twinsen's inquiry and propose to recite three different passages from the book.

If Twinsen asks about Pirate Recipes, the NPC will make a joke, but then if you keep pressing space, the dialogue will "continue" infinitely with empty dialogue boxes.

The user can get unstuck if they press Esc through.

This bug does not happen with the other dialogue options.

[mgerhardy]

hero_pos 10661 4352 20462

It looks like this string has a lot of whitespaces to fill the empty space and only a single word in on the last page of the text (at least in german). The error is most likely related to the return value of Text::updateProgressiveText() - i will check the NextDialCar in the original sources.

[mgerhardy]

should be fixed with commit 4453d048646e3d1f1e5e0b6f2d1ce7b1109b4b9c