Opened 17 years ago

Closed 17 years ago

Last modified 2 years ago

#1538 closed defect (fixed)

GUI: BrowserDialog return value

Reported by: wjp Owned by: fingolfin
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

Pressing escape in the BrowserDialog sets the return value to -1 (Dialog::handleKeyDown)

LauncherDialog::addGame() interprets any non-zero return value as a successful selection.

Result: crash when attempting to get/use the selected directory.

(Latest scummvm anon-CVS)

Ticket imported from: #917532. Ticket imported from: bugs/1538.

Change History (5)

comment:1 by fingolfin, 17 years ago

Owner: set to fingolfin
Resolution: fixed

comment:2 by fingolfin, 17 years ago

Should be fixed in CVS; please test.

comment:3 by wjp, 17 years ago

I'll test the 'real' CVS version when it filters through to anonymous CVS.

In the meantime I added the '> 0' check in launcher.cpp (the location I reported) manually, and that indeed fixes that crash, as expected.

comment:4 by fingolfin, 17 years ago

Status: newclosed

comment:5 by digitall, 2 years ago

Component: --Unset--GUI
Note: See TracTickets for help on using tickets.