Opened 20 years ago

Closed 20 years ago

Last modified 5 years ago

#1533 closed defect (fixed)

GUI: "Graphics mode" setting is disabled

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: GUI
Version: Keywords:
Cc: Game:


In the global options dialog, i.e. the one you get when pressing the "Options" button in the launcher dialog, the "Graphics mode" setting is disabled.

The "enabled" flag for this widget is manipulated in two places in options.cpp: In setGraphicSettingsState(), and in open(). I suspect it's the latter that's causing trouble here.

(This was discussed briefly on IRC yesterday. I just want to make sure that it's not forgotten.)

Ticket imported from: #916498. Ticket imported from: bugs/1533.

Change History (10)

comment:1 by eriktorbjorn, 20 years ago

Owner: set to fingolfin

comment:2 by SF/renatoriolino, 20 years ago

I'm posting this here because I think they're related.

The "Graphics mode" setting is disabled when I'm using Xinerama on X11 (Linux) and I can't go in full screen mode.

Disabling Xinerama everything works fine (including full screen). I think that SCUMM don't like screen resolutions like 2048x768.



comment:3 by eriktorbjorn, 20 years ago

> I'm posting this here because I think they're related.

Almost certainly not. This bug report is about whether or not a GUI widget is active, while yours is about whether or not the graphics backend is able to switch to fullscreen.

I don't know anything about Xinerama, though. According to the list of major SDL changes since 1.0.0 it is supported - "1.2.3: Added X11 Xinerama support - fullscreen starts on screen 0" - but maybe it's an SDL bug. Or maybe your SDL library was built without Xinerama support.

But, as I said, it almost certainly has nothing to do with this particular bug report.

comment:4 by SF/renatoriolino, 20 years ago

I think my SDL was compiled with Xinerama support because others SDL apps and games are working well in fullscreen.

Anyway, SCUMM go in fullscreen but the game screen stay on the center of my screen 0 (it should get resized to the size of the display 0).

I'll recompile SDL tonight to certificate that it's with xinerama enabled and if the problem persist I'll open a new bug.

Thanks for helping.


comment:5 by fingolfin, 20 years ago

Status: newclosed

comment:6 by fingolfin, 20 years ago

Enabling the button isn't the problem (just remove the _gfxPopUp- >setEnabled(false); from OptionsDialog::open() )

However, the popup will be mostly useless to the user -- effects only take place after restarting ScummVM.

There have been various mails on scummvm-devel on the subject how to implement an option dialog "properly", this ties into the problem described in here (i.e. it explains why I didn't bother much to do anything about this here).

Still, I enabled the popup for now, at least it has a small use factor (a really small one :-).

comment:7 by fingolfin, 20 years ago

Resolution: fixed

comment:8 by digitall, 5 years ago

Component: --Unset--GUI

comment:9 by Filippos Karapetis <bluegr@…>, 5 years ago

In 94bf3265:

SCI: Fix SQ4CD Sock's door, bug #10914 (#1533)

comment:10 by digitall, 5 years ago

The previous comment was automatically added by pattern matching of #1533 in that comment as a bug artifact id. However, this was actually a reference to the Pull Request id and is unrelated to this bug. Not sure how to avoid this in future.

Note: See TracTickets for help on using tickets.