Opened 6 weeks ago
Last modified 6 weeks ago
#15293 new defect
AGI: LSL1: When the same message is repeated, it's not obvious that they're individual messages
Reported by: | eriktorbjorn | Owned by: | |
---|---|---|---|
Priority: | normal | Component: | Engine: AGI |
Version: | Keywords: | ||
Cc: | Game: | Leisure Suit Larry 1 |
Description
When you give the whiskey to the drunk, the message "...my only posshhess... hhic!" is repeated three times.
Unless you're in on the joke, you may think the game has locked up because nothing seems to happen when you press Enter to dismiss the text box. This is similar to the lottery messages in LSL2. The problem was fixed there, so maybe it can be fixed here as well even though it's a different engine?
The quick-and-dirty fix might be something like this:
diff --git a/engines/agi/text.cpp b/engines/agi/text.cpp index 06773598849..eefbdc263cc 100644 --- a/engines/agi/text.cpp +++ b/engines/agi/text.cpp @@ -558,6 +558,8 @@ void TextMgr::closeWindow() { const int16 x = _messageState.backgroundPos_x; const int16 y = MAX<int16>(0, _messageState.backgroundPos_y); _gfx->render_Block(x, y, _messageState.backgroundSize_Width, _messageState.backgroundSize_Height); + _gfx->updateScreen(); + _vm->_system->delayMillis(50); } _messageState.dialogue_Open = false; _messageState.window_Active = false;
With some appropriate comment, of course. But maybe there's a better way?
(I just felt a tiny disturbance in the Force, as if a small handful of speedrunners suddenly cried out in terror and were suddenly silenced.)
Attachments (1)
Change History (3)
by , 6 weeks ago
comment:1 by , 6 weeks ago
comment:2 by , 6 weeks ago
Summary: | AGI: LSL1: Insufficient feedback when the same text box is repeated → AGI: LSL1: When the same message is repeated, it's not obvious that they're individual messages |
---|
Simplified version of the patch: