AGS: Incorrect Use of Bitwise XOR Operator in Distance Calculation [upstream bug]

[RainRat]

scummvm/blob/master/engines/ags/shared/util/geometry.cpp:

The function DistanceBetween in this code uses the bitwise XOR operator (^) instead of the multiplication operator (*) when calculating the square of distances. This results in incorrect distance calculations.

Current Code:

return static_cast<float>(std::sqrt((inner_width ^ 2) + (inner_height ^ 2)));

Expected Code:

return static_cast<float>(std::sqrt(inner_width * inner_width + inner_height * inner_height));

[tag2015]

Well spotted! This is an upstream bug, as you can see here
​https://github.com/adventuregamestudio/ags/blob/master/Common/util/geometry.cpp

This should definitely be fixed, hopefully it won't break games that expect this "broken" calculation (it seems this function is only used by FindNearestViewport, though)

I'll open a bugreport on the AGS bugtracker

[tag2015]

Reported and fixed upstream ​https://github.com/adventuregamestudio/ags/issues/2485

[tag2015]

In 78ee37a1:

AGS: Common: fixed wrong calculation in DistanceBetween()

From upstream c5f8c5374024b71493d276a27daa38d1aac84a89
Fix #15292