SCUMM: INDY3 (EGA): Wrong text color in the ending when indy dies

[gabberhead]

when indy dies or at the end of the game with the score table and the credits, all letters are in black and it is hard to read. tried with scummvm. i watched some videos with the amiga game version with winuae and dos/ega version with dosbox, when indy dies, the letters are in yellow and at the score table in the end and the credits are also in different colors. with vga and fmtowns version, there is no problem. only the ega versions seems to be affected.

[AndywinXp]

This is a regression from 2.8.1, where the colors work as intended.

[dwatteau]

Thank you very much for reporting this regression!

I did a Git bisect and commit 6857eb56babdb9389f76bab75a1ef2cb2d7b03cd ("SCUMM: (LOOM/EGA/AMIGA) - add missing shadow mode") was found to have introduced the issue. This was related to the implementation of Trac ticket #15030.

Knowing what part of the code introduced the regression should help fixing it...

[dwatteau]

This should be fixed by commit 9c2eaa921514ddd90ed3ec1be87d5caf14bb65c7 from athrxx ("SCUMM: (INDY3/EGA) - fix text color regression").

@gabberhead: Could you confirm whether a new daily build (​https://scummvm.org/downloads/#daily) after the next 24 hours fixes the issue for you?

Thanks

[gabberhead]

ok. i will download tomorrow the latest daily build and try it.

[gabberhead]

its workin again with the todays daily build for both ega version, dos and amiga. when u have time, u can also look into this feature request for indy 3 dos ega version:

https://bugs.scummvm.org/ticket/15227

[dwatteau]

@gabberhead: Thank you for your report and your test, this is very appreciated.

I'm closing the current ticket then, but I'll reply in the other one you've mentionned just after that.