DIRECTOR: Bad palette in The Dark Eye

[eriktorbjorn]

In The Dark Eye (v1.0/Windows/English), once the game starts the palette is messed up, like this:

I've chosen this screenshot because it demonstrates that certain elements in the image may still have the correct palette. This is a recent regression. Bisecting points to this commit:

bde3fe3f77bb201d4a90d3883a7be7c62435496e is the first bad commit
commit bde3fe3f77bb201d4a90d3883a7be7c62435496e
Author: Scott Percival <code@moral.net.au>
Date:   Tue May 28 16:07:20 2024 +0800

    DIRECTOR: Reset palette in use on movie switch

    Previously if there was a movie switch, and the two movies used
    different custom palettes with the same cast ID, there was no
    mechanism to force a swap to the new palette.

    Fixes palette glitches in Die Hexenakademie.

 engines/director/castmember/palette.cpp |  9 ++++++++-
 engines/director/castmember/palette.h   |  1 +
 engines/director/graphics.cpp           | 28 ++++++++++++++++++++++++++--
 engines/director/window.cpp             |  1 +
 4 files changed, 36 insertions(+), 3 deletions(-)

[eriktorbjorn]

Appears to be fixed now. See ​https://github.com/scummvm/scummvm/commit/4b4f4da44fd775f634694be9f09da51a7a015f6a for details.