SCUMM: Autosave warnings still pop up when classic menus are used

[antoniou79]

This was tested with ScummVM 2.8.1 and also a local build from current master HEAD for 2.9.0git on Windows 10.

The report is based on a thread opened on the ScummVM forums here:
​https://forums.scummvm.org/viewtopic.php?t=17101

Affected seemed to be all SCUMM games that have the option to "Enable the Original GUI and Menu".

The main issue seems to be thus:

• Currently when the option for using the original GUI and Menu is checked for a game, autosaving gets disabled. See: ​https://github.com/scummvm/scummvm/blob/56fdb8d2f3b327dede6406a65ac4dde134a15ffa/engines/scumm/saveload.cpp#L142

• In this case (using the classic GUI menus), if autosaving is enabled from the Global Options, the user still gets prompted to move their save game from the autosave slot (0 for GMM, 1 for classic menu), delete it or ignore the message; with the latter case being that they will get again prompted 5 minutes later about this. Regardless of what the user chooses, no new autosave will actually be created in the autosave slot.

Since the autosave slot overwrite warning prompt depends on a flag being set here from the result of canSaveAutosaveCurrently(): ​https://github.com/scummvm/scummvm/blob/56fdb8d2f3b327dede6406a65ac4dde134a15ffa/engines/engine.cpp#L648
it seems that overriding that method (canSaveAutosaveCurrently()) for the SCUMM engine and including in the implementation the check for isUsingOriginalGUI(), would result in skipping the warning prompt altogether, so that might be a potential fix for this.

Additionally, it might be worth considering adding some info on the checkbox option for enabling the classic GUI, that autosaving will be disabled while that's activated.

[AndywinXp]

In 51b34c33:

SCUMM: Explicitly disable autosaving when original GUI is active

This addresses #15063:
"SCUMM: Autosave warnings still pop up when classic menus are used"

The implemented solution was proposed by antoniou79.

[AndywinXp]

Sorry it took this long for me to look at this ticket. Does the solution look acceptable? If so, feel free to close the ticket.

[antoniou79]

This looks ok to me (just tested). Thank you for the fix.

My only issue is that both on the daily build on the ScummVM buildbot, and on a local build I couldn't get the new augmented popup text for the "Enable the original GUI and menu" checkbox. I seem to remember that something else (running an auxiliary script?) may be needed to update the texts, though, so it's probably not something needing a fix.