Opened 7 weeks ago

#15053 new defect

BACKENDS: AMIGAOS: another unsupported GL uniform?

Reported by: raziel- Owned by:
Priority: normal Component: Port: AmigaOS4
Version: Keywords: GL, OGLES2, gl4es, shader
Cc: Game: The Longest Journey

Description

ScummVM 2.9.0git (Apr 2 2024 23:06:32)
Using SDL backend with SDL 2.30.1
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 OpenMPT Theora VPX AAC A/52 FreeType2 FriBiDi JPEG PNG GIF cloud (servers, local) ENet SDL2 TinyGL OpenGL (with shaders)

@lephilousophe fixed unsupported uniform booleans in this commit in shader.cpp
https://github.com/scummvm/scummvm/commit/c9b4949746ef86eb1d35ba39efaa2f63f37b596b

Now i'm getting something similar in shader.h, line 150 and was wondering if this is the same kind of error and if it could be worked around as easily?

This is what i get in the log and it seems as if it slows down the game too (due to it's massive spamming)

"WARNING: GL ERROR: GL_INVALID_OPERATION on glad_glUniformlf(pos, f) (./graphics/opengl/shader.h:150)!"

and this is the piece of source in graphics/opengl/shader.h where it stems from, the GL_CALL being the one to blame

	// Different name to avoid overload ambiguity
	bool setUniform1f(const Common::String &uniform, float f) {
		GLint pos = getUniformLocation(uniform);
		if (pos != -1) {
			use();
			GL_CALL(glUniform1f(pos, f));
			return true;
		} else {
			return false;
		}

The Longest Journey (Windows/English)

This was compiled with a gl4es patched SDL2 to not use minigl, but instead relay and access everything from gl4es...with minigl this i never saw, so i guess it might be a missing/unsupported function from the gl4es package(?)

Any help appreciated, thank you very much

AmigaOS4 - PPC - BigEndian
gcc (adtools build 11.3.0) 11.3.0

Change History (0)

Note: See TracTickets for help on using tickets.