Opened 3 months ago

Closed 3 months ago

#15000 closed defect (fixed)

AGI-FANMADE: V Demo doesn't recognize valid word "ammunition"

Reported by: dfsgand Owned by: antoniou79
Priority: normal Component: Engine: AGI
Version: Keywords: vocabulary script
Cc: dfsgand Game: AGI Fanmade

Description

ScummVM versions checked:
ScummVM 2.2.0 (Jan 15 2021 17:10:38)
ScummVM 2.9.0git2162-g0377f34e8ea (Feb 28 2024 15:21:33)
Platform: Debian 11.9 bullseye, x86-64

Game: agi-fanmade: V - The Graphical Adventure (Demo 2) (DOS/English)
Download URL: https://web.archive.org/web/20170331152016/http://brainburst.de/v/V_Demo.zip

Upon getting player control, typing "get ammunition" returns: '"ammunition" is not in my vocabulary.' but picking up some ammunition is required to progress later in the game.

This works on nagi: typing "get ammunition" on the initial screen produces a "can't do that" response like "So sorry, Sir, but we sold out on that on Wednesday", indicating that nagi recognized the word. The ammo can also be picked up later in the game where it's present.

Change History (2)

comment:1 by antoniou79, 3 months ago

It actually seems that our AGI engine code was skipping most (or all) of the valid words that started with "a" for this game. With some quick debugging, it seemed to pick up about two or three of those but with bad prefix (ie. not actually "a").

I've issued a PR with a potential fix, which works for me, and also seems to still work with Space Quest 0 (a fan game for which we've had to add a work around for our word parsing code for the dictionary).

PR is here: https://github.com/scummvm/scummvm/pull/5676

Last edited 3 months ago by antoniou79 (previous) (diff)

comment:2 by sluicebox, 3 months ago

Owner: set to antoniou79
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.