Opened 4 months ago

Closed 4 months ago

#14874 closed defect (fixed)

SCI: HOYLE4: Accidental soft-lock possible in Euchre

Reported by: Karunamon Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: original
Cc: Game: Hoyle's Classic Card Games

Description

This title uses the right mouse button as a shortcut to move a card to the most logical place.

If you begin a game of euchre, and pick up the card on the stack in front of you, you can double right click on your hand and put down an extra card that you shouldn't be able to. You now have one less card than everyone else, eventually it will be your turn and you have nothing to play. The only thing you can do at this moment is leave the game.

This problem does exist on the original DOS executable, and ScummVM reproduces it accurately.

Attachments (1)

users-and-groups-1.jpg (34.8 KB ) - added by Karunamon 4 months ago.

Download all attachments as: .zip

Change History (5)

by Karunamon, 4 months ago

Attachment: users-and-groups-1.jpg added

comment:1 by tag2015, 4 months ago

Summary: Accidental soft-lock possible in hoyle4 euchreSCI: HOYLE4: Accidental soft-lock possible in Euchre

comment:2 by tag2015, 4 months ago

Component: --Unset--Engine: SCI

comment:3 by sluicebox, 4 months ago

Keywords: original added
Priority: lownormal

Thank you for reporting this and confirming it's an issue in the original game.

I'm happy I don't have to learn euchre (again??) to investigate this =)

comment:4 by sluicebox, 4 months ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Fixed in: https://github.com/scummvm/scummvm/commit/f5aec9593b87deab2925a726f6dbd4edaa5805cc

The script was missing a HandsOff call that similar scripts have. Now input is disabled as soon as that first special discard begins.

I tested this the best I could without knowing Euchre, so if there are any issues with this fix just re-open this ticket. I'm not expecting any though; this seemed straight forward.

Thanks again!

Note: See TracTickets for help on using tickets.