Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#1481 closed defect

BS1: .pal files have to be in the current directory

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: Sword1
Keywords: Cc:
Game: Broken Sword 1

Description

I'm sure this is a known bug, but just to make reasonably sure it isn't forgotten: The cutscene player for Broken Sword I requires the .pal files to be in the current directory, which is not good.

Assigning to Ender, since as far as I know he's the only one who knows what the official cutscene packages are going to look like.

Ticket imported from: #902154. Ticket imported from: bugs/1481.

Attachments (2)

palconvert.c (987 bytes ) - added by eriktorbjorn 17 years ago.
Quick-and-dirty .pal file converter
bs-binary-palette.diff (2.8 KB ) - added by eriktorbjorn 17 years ago.
Patch against a February 22 branch snapshot

Download all attachments as: .zip

Change History (17)

comment:1 by eriktorbjorn, 17 years ago

Owner: set to SF/ender

comment:2 by SF/ender, 17 years ago

Owner: changed from SF/ender to eriktorbjorn

comment:3 by SF/ender, 17 years ago

This is also true for BS2, and there is indeed a FIXME in there (or at least in the BS2 code) about this.

The .pal files need to be converted to a binary format so we can use the File class. When this happens it'll look in "all the usual places". If you want to do the conversion and bounce me over the new .pal files, that'd be cool. :)

by eriktorbjorn, 17 years ago

Attachment: palconvert.c added

Quick-and-dirty .pal file converter

by eriktorbjorn, 17 years ago

Attachment: bs-binary-palette.diff added

Patch against a February 22 branch snapshot

comment:4 by eriktorbjorn, 17 years ago

I don't have the final .pal files, so I can't do the conversion. But I used the attached tool to convert the first two .pal files of the experimental BS2 cutscenes, and it seemed to work fine for them.

The patch also includes the corresponding changes to the BS1 cutscene player, but these are completely untested. I haven't even tried to compile them. Caveat emptor.

comment:5 by eriktorbjorn, 17 years ago

Owner: changed from eriktorbjorn to SF/ender

comment:6 by eriktorbjorn, 17 years ago

Assigning to Ender again. Your move. ;-)

comment:7 by eriktorbjorn, 17 years ago

By the way, in this patch / converter the 'cnt' parameter is stored as a 16-bit integer. It should be trivial to change this to a byte, since it's never larger than 256.

comment:8 by SF/ender, 17 years ago

I don't have any BS1 .pal files at all, anyway. There ARE no final BS1 .pal files :)

If you have some feel free to share *g*

comment:9 by eriktorbjorn, 17 years ago

I have neither the tools nor the expertise to encode the cutscenes.

comment:10 by SF/ender, 17 years ago

Cutscenes I have, .pal 8-bit palette files I don't. I assumed you had made some since you logged this bug :o)

comment:11 by eriktorbjorn, 17 years ago

No, on the few occasions where I've tested the BS1 cutscene code at all I've used files from the preliminary BS2 cutscene pack. That's when I noticed that the BS2 looks for .pal files in the game data directory, whereas BS1 looks in the current directory.

comment:12 by SF/ender, 17 years ago

Status: newclosed

comment:13 by SF/ender, 17 years ago

Closing this, I'll commit the appropriate code when I update the cutscene packs on Monday/Tuesday.

comment:14 by eriktorbjorn, 17 years ago

Looks to me as if it was only committed to the branch. What about the trunk?

comment:15 by SF/ender, 17 years ago

Was meaning to backport it, but I was a bit rushed for time. Feel free to do so, otherwise I'll try and look at it this weekend.

Note: See TracTickets for help on using tickets.