#14791 closed defect (fixed)
SCI: LSL5 stack index crash
| Reported by: | EricTSten | Owned by: | sluicebox |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | ||
| Cc: | Game: | Leisure Suit Larry 5 |
Description
ScummVM version - 2.8.0 (Dec 17 2023 13:36:20)
In the game when completing the Doc Pullam "quest". When the game goes to the non-interactive end sequence for the quest when Larry crashes into the wall and right after the sound is played and dialog is displayed the game freezes and crashes with the following error:
ERROR: [lsl5-1.000 920/999 Obj::isKindOf @ 018c]: [VM] Stack index 4096 out of valid range [0..4095]!
I have loaded an earlier save game and went through the game to the same point and had the same crash. It also happens when loading the save game on a different system.
Language: English
Version of game: DOS - from GOG
OS: macOS Sonoma 14.2 (also occurs in Windows 11 x64)
Attachments (2)
Change History (7)
by , 11 months ago
by , 11 months ago
| Attachment: | image-20240101-143836.png added |
|---|
comment:1 by , 11 months ago
comment:2 by , 11 months ago
| Component: | --Unset-- → Engine: SCI |
|---|---|
| Owner: | set to |
| Resolution: | → fixed |
| Status: | new → closed |
| Summary: | Leisure Suit Larry 5 stack index crash → SCI: LSL5 stack index crash |
Fixed in: https://github.com/scummvm/scummvm/commit/d2efce1c64470686bfbcc4e146edd84c06f46b89
Ooof, this was a regression I introduced in March.
Thanks again for reporting this! The fix will appear in our next daily build: https://www.scummvm.org/downloads/#daily
This is a pretty bad bug on my part, so if you don't want to use daily builds for some reason, let me know and I'll make something that works around this.
comment:3 by , 11 months ago
I'm fine with installing the daily build to fix this. Thank you for looking into this so quickly.
Eric Sten
comment:4 by , 11 months ago
On the plus side, we have a data point: LSL5 isn't as popular as I thought! I'm really surprised it took so long to hear about this. When a game breaks like this, people notice!
We had one vague report of crashes last year but no steps to reproduce, or screenshots, or save games, and no response to requests for more information, so I had to close it. It was likely this bug, but who knows. Thank you for providing everything I needed to reproduce!
Hello and Happy New Year! Thank you for reporting this, it looks quite serious.
This can be reproduced from scratch by starting a new game and using the debugger to go to room 920. As you said, infinite recursion occurs during the non-interactive scene. I've tried several game versions and they all crash. That's bad!