Opened 11 months ago

Closed 5 days ago

#14778 closed defect (fixed)

TWINE: Some in-game options are being translated to ???

Reported by: antoniou79 Owned by: mgerhardy
Priority: normal Component: Engine: TwinE
Version: Keywords: translation, broken, menu, options
Cc: Game: Little Big Adventure

Description

This is on 2.8.0 official release and also on 2.9.0git from current master HEAD on Windows 10 x64 machine.

I'm testing with GOG's version of LBA1, English.

Issue description:
When I select Greek as the GUI language for ScummVM (from the launcher > Global Options > GUI > GUI Language) then, while playing LBA1, some in-game options are being "translated" to a series of "?" characters.

I suspect the game engine is picking up the translation of these options from the weblate, since these options are also available from the ScummVM GUI, in the "Edit Game... > Game (Tab)" screen, but since there are no fonts for non-ASCII language glyphs it displays ??? instead.

Maybe the engine in-game should not use the weblate translations?

I am attaching screenshots from the game to showcase how it shows in English and Greek.

Attachments (6)

scummvm-lba-win-1-00000-en.png (281.8 KB ) - added by antoniou79 11 months ago.
scummvm-lba-win-1-00000-gr.png (772.0 KB ) - added by antoniou79 11 months ago.
scummvm-lba-win-1-00001-en.png (286.8 KB ) - added by antoniou79 11 months ago.
scummvm-lba-win-1-00001-gr.png (800.9 KB ) - added by antoniou79 11 months ago.
scummvm-lba-win-1-00002-en.png (298.4 KB ) - added by antoniou79 11 months ago.
scummvm-lba-win-1-00002-gr.png (830.7 KB ) - added by antoniou79 11 months ago.

Change History (11)

by antoniou79, 11 months ago

by antoniou79, 11 months ago

by antoniou79, 11 months ago

by antoniou79, 11 months ago

by antoniou79, 11 months ago

by antoniou79, 11 months ago

comment:1 by antoniou79, 11 months ago

The affected texts, as far as I can tell, seem to be:
"High resolution (on/off)"
"Wall collision (on/off)"
"Language selection"
"Voices: (English/French/German/None)"

comment:2 by mgerhardy, 11 months ago

TwinEMetaEngineDetection::toDetectedGame() could get overridden to limit the languages.

TextData::initCustomTexts() adds the custom translations.

comment:3 by mgerhardy, 2 months ago

Hint for a future me:

Characters in the twine engine are encoded in the extended ASCII standard (Western Europe (DOS/OS2-437/US)) character set. See https://www.asciitable.com/ for a list of characters - also check out https://www.lookuptables.com/text/alt-codes for the ALT codes.

comment:4 by mgerhardy, 5 days ago

In 0aa23d5e:

TWINE: fixed issue #14778 (translation for custom texts)

.. by removing the translations for now

comment:5 by mgerhardy, 5 days ago

Owner: set to mgerhardy
Resolution: fixed
Status: newclosed

0aa23d5e23d741aca3f17d983235d8b39467a7c1 removed the gettext markers

Note: See TracTickets for help on using tickets.