Opened 13 months ago

Closed 2 weeks ago

#14684 closed defect (fixed)

DOCUMENTATION: The Wiki documentation and CLI parameter commentary of the --scaler CLI parameter are wrong.

Reported by: JuanMiguelBG Owned by: sev-
Priority: normal Component: Documentation
Version: Keywords:
Cc: Game:

Description

The Wiki documentation and CLI parameter commentary of the --scaler CLI parameter are wrong.

The wrong value is tv2x. This value is used in the --gfx_mode CLI parameter.

The right TV plugin value to the --scaler CLI parameter is tv.

You can check on the Scummvm source code:

base\plugins.cpp - line 1081 - tv2x value definition on the s_legacyGraphicsModes variable declaration
https://github.com/scummvm/scummvm/blob/v2.7.1/base/plugins.cpp#L1081

base\plugins.cpp - line 1084 - isOldGraphicsSetting() function declaration that uses s_legacyGraphicsModes variable
https://github.com/scummvm/scummvm/blob/v2.7.1/base/plugins.cpp#L1084

base/main.cpp - line 562- isOldGraphicsSetting() function call based on the gfx_mode definition
https://github.com/scummvm/scummvm/blob/v2.7.1/base/main.cpp#L562

The Scummvm documentation is wrong.

base/commandLine.cpp - line 118 - scaler CLI parameter comentary

Scummvm Wiki command line https://docs.scummvm.org/en/latest/advanced_topics/command_line.html

Change History (3)

comment:1 by tag2015, 13 months ago

Summary: The Wiki documentation and CLI parameter commentary of the --scaler CLI parameter are wrong.DOCUMENTATION: The Wiki documentation and CLI parameter commentary of the --scaler CLI parameter are wrong.

comment:2 by sev-, 2 weeks ago

In cbb066ca:

DOCS: Fix 'tv2x' scaler parameter. Bug #14684

comment:3 by sev-, 2 weeks ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

Thank you, fixed

Note: See TracTickets for help on using tickets.