ACCESS: File not closed after exit (Guardians of Eden)

[GandalfTheWhite80]

• Start "Amazon: Guardians of Eden"
• close the game after the intro with the "x"
• the "TDROM\GAME\ETEXT1.DAT" won't be closed / there is a file lock on this file until closing scummvm

• svummvm daily (2.8.0/Sep 3.2023)
• win64 (win10)
• Amazon: Guardians of Eden GOG Version

[PushmePullyu]

Thanks for the report!

This seems to be a file handle leak caused by the following code:
in engines/access/amazon/amazon_logic.cpp:
in void CampScene::mWhileDoOpen():

if (_vm->_conversation != 2) {
		// Cutscene at start of chapter 1
		screen.setPanel(3);
		_vm->startChapter(1); // <--------- this calls loadEstablish(int)
		_vm->establishCenter(0, 1); // <--- this also calls loadEstablish(int) 
	}

The first call to loadEstablish() assigns a new Resource to Access::Resource *Access::AccessEngine::_establish. This resource holds a file handle for "ETEXT1.DAT".
The second call now reassigns to _establish, so the Resource it pointed to previously is lost, including the file handle.

PR with fix is here: ​https://github.com/scummvm/scummvm/pull/5310

[bluegr]

Th PR has been merged. Thanks!