SQ6 DEMO Closing Inventory screen with Escape causes crash under certain conditions

[Twixxi691]

In the Space Quest 6 Interactive Demo (which has a different plot, items and interactions from the actual SQ6) there is a crash which can occur in the Inventory screen.

If you select an item and then close the Inventory using the Escape key (rather than hitting the Play button) and the Item you have selected is subsequently removed from your Inventory, the game will crash when you next open the Inventory screen.

In the demo there are only two occasions that an item is removed from your Inventory while your Inventory screen is not open: Plugging the Clapmaster into the socket on the bridge, or placing the Bjorn Chow on the command chair on the bridge. The error codes produced are:
Clapmaster - kUpdateScreenIten: Screen item 002b:1c5c not found in place 002b:24ef!
Bjorn Chow - kUpdateScreenIten: Screen item 002b:1a88 not found in place 002b:24ef!

The crash will occur even if you travel to another room prior to opening the Inventory for the second time. If your Inventory is empty after the item is removed, the crash will occur when you pick up another item and then open the Inventory screen. It does not matter whether you press TAB or click the Inventory button to open the Inventory.

Unfortunately I cannot provide a Save File as saving is disabled in the demo. The quickest method to reproduce the bug is as follows:

• Enter the shuttle and obtain the two items from the glovebox
• Use the ComPost to travel to 8-Rear
• Use the replicator and enter code 7469410
• Take the Bjorn Chow and use the ComPost to travel to the Bridge
• Open your Inventory, select Bjorn Chow, use Escape to close the Inventory, and place the Bjorn Chow on the chair
• Open your Inventory and the game will crash

Footage will be attached below.

The Workaround is to always close the Inventory with the Play button when using the Clapmaster and the Bjorn Chow.

[Twixxi691]

Footage is too big to upload here, so popped them on YouTube:

Normal playthrough showing crash that occurs after using Clapmaster: ​https://www.youtube.com/watch?v=upsh7xQ9EV4

Full playthrough showing the workaround to skip the crash: ​https://www.youtube.com/watch?v=IXHSkBk_b4k

Quickest method to reproduce using the Bjorn Chow: ​https://www.youtube.com/watch?v=v8GBvjcs2GU

Demonstration that crash can occur even if you travel to a different room first: ​https://www.youtube.com/watch?v=veyKYkXyjkU

[sluicebox]

Fixed in ​https://github.com/scummvm/scummvm/commit/f16f8c792fd0827ff55c947752e9120fd4c7d52b

Thanks for reporting this!