SCUMM: INDY3 (MAC): copyRectToSurface assert fails when loading a save

[dwatteau]

Trying to load my Indy3 EGA Macintosh saves from last year, the following assert appears to always be triggered:

Assertion failed: (destX >= 0 && destX < w), function copyRectToSurface, file surface.cpp, line 169.

I'm loading the saves from the GMM, I'm using original_gui=true and it's a debug build. The saves do work with the same setup in ScummVM 2.7.0.

Git bisect tells me that this is related to commit dd1232325d9b310a85244f78ca5d12c063cf047f (GRAPHICS: Add support for cursor as Surface).

Attaching the save and the backtrace below.

[dwatteau]

LLDB backtrace when the assert is triggered

[dwatteau]

Example of an Indy3 EGA Macintosh save triggering the assert in current Git master

[dwatteau]

Possibly related to issue #14468, in some way?

[AndywinXp]

Thanks! Should be fixed now :-)

[dwatteau]

It's all good! My 40 saves for this game now all load without any issue.

Thank you very much for the very quick fix!