NANCY: SCK - Wrong colors on BE target

[raziel-]

ScummVM 2.8.0git (May 15 2023 22:17:09)
Using SDL backend with SDL 2.26.5
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 MikMod Theora VPX AAC A/52 FreeType2 FriBiDi JPEG PNG GIF cloud (servers, local) ENet SDL2 TinyGL OpenGL (with shaders)

See attached screenshot, color conversion gone wrong (if there is any)

Nancy Drew: Secrets Can Kill (Windows/English)

AmigaOS4 - PPC - Big Endian
gcc (adtools build 11.3.0) 11.3.0

[fracturehill]

I'm obscenely late on responding to this, my apologies :)
The issue seems to be a simple case of image/video data endianness not being converted. I've just pushed what I believe is a fix, but I don't have a big endian machine to test it on, so I'd appreciate if you gave it a try to confirm.

[raziel-]

No problem, thank you very much.

I will test asap...unfortunately that will have to wait till october since im back at work, sorry :-/

[raziel-]

@fracturehill

Confirmed fixed :-D

Sorry for the delay

[raziel-]

Sorry, but the wrong colors are back :-/

Somehow a regression snuck in

[fracturehill]

Yes, I rewrote the engine's resource management last week and apparently broke the LE->BE conversion. I've pushed a fix to master, let me know if everything works correctly.

[raziel-]

Fixed again :-)

Thanks a lot for the instant reaction

[fracturehill]

No, thank you for testing! I'm re-marking this as resolved, hopefully this will be the last time I touch this ticket :)