Opened 2 years ago

Closed 6 months ago

Last modified 6 months ago

#14342 closed defect (fixed)

TETRAEDGE: Game started from fullscreen launcher is not in fullscreen

Reported by: Thunderforge Owned by: bluegr
Priority: high Component: Engine: Tetraedge
Version: Keywords:
Cc: Game: Syberia 1

Description (last modified by Thunderforge)

When Syberia or Syberia II are started from the ScummVM launcher while it is in fullscreen, the game is not started in full screen.

Reproduction Steps

  1. Start ScummVM
  2. Enter fullscreen mode (option + enter)
  3. Lauch Syberia or Syberia II

The game will launch, but not in fullscreen.

Versions Tested

  • ScummVM 2.8.0 Daily 2023-03-16
  • Syberia 1.0.2 macOS (GOG release)
  • Syberia II 1.0.0 macOS (GOG release)

Change History (7)

comment:1 by Thunderforge, 2 years ago

Description: modified (diff)

comment:2 by somaen, 7 months ago

Priority: normal → high

Would be good to resolve this for the 2.9.0 release.

comment:3 by tag2015, 6 months ago

I can replicate the issue on Windows, but I think this is not restricted to Tetraedge.
The same thing happens in Myst 3 or Thimbleweed Park, for example.

comment:4 by mduggan, 6 months ago

Yes, this doesn't appear to be Tetraedge-specific, it's not doing anything unusual - just calling initGraphics3d.

I think the problem is actually inside the way initGraphics3d interacts with OpenGLSdlGraphics3dManager. It seems to do multiple resizes and resets of the surface in a short time and ends up a bit confused? I haven't fully traced through the code though.

comment:5 by Filippos Karapetis <bluegr@…>, 6 months ago

In eb7b6b97:

ENGINES: Use common GFX code for 3D games - fixes part of bug #14342

Now, when the launcher is in full screen, the game will also be in full
screen. However, when returning to the launcher, graphics are reset to
default with a setupGraphics() call. Thus, if the user hasn't selected
full screen display in the options, but only used alt-enter to change
the launcher to full screen, the launcher will return to window mode.

comment:6 by mduggan, 6 months ago

Owner: set to bluegr
Resolution: → fixed
Status: new → closed

The above patch fixes this issue. There are still some small issues with switching as mentioned in the commit, but they are comparatively minor.

comment:7 by Filippos Karapetis <bluegr@…>, 6 months ago

In 514bb7fb:

ENGINES: Use common GFX code for 3D games - fixes part of bug #14342

Now, when the launcher is in full screen, the game will also be in full
screen. However, when returning to the launcher, graphics are reset to
default with a setupGraphics() call. Thus, if the user hasn't selected
full screen display in the options, but only used alt-enter to change
the launcher to full screen, the launcher will return to window mode.

Note: See TracTickets for help on using tickets.