TETRAEDGE: Quitting from the main menu of Syberia II freezes ScummVM if "Return to the launcher" is set

[Thunderforge]

When quitting from the main menu in Syberia II, ScummVM freezes.

Reproduction Steps

1. In the ScummVM launcher, go to "Global Options" → "GUI" and then check "Return to the launcher when leaving the game"
2. Launch Syberia II in ScummVM
3. On the main menu, click "Exit Game"

The music will continue but ScummVM will freeze.

Versions Tested

• ScummVM 2.8.0 Daily 2023-03-14 macOS x64
• Syberia II 1.0.0 macOS (GOG release)

[Thunderforge]

Also, the console says this when you click on "Exit Game":

mouse clicked button 'quitButton' (from leftup)
TeCore::findFile Searched but didn't find menus/confirm/confirmQuit.lua
WARNING: File::open: node does not exist!
WARNING: TeLuaThread::executeFile: File confirmQuit.lua can't be opened!
WARNING: confirm script not loaded, default to Yes.!

[Thunderforge]

I found out that this only happens if you go to the ScummVM Launcher -> Global Options -> GUI and then check "Return to the launcher when leaving the game". If that option is unchecked, there is no freeze.

[criezy]

I created a pull request that fixes this issue.
It also fixes a separate issue when the Ask for confirmation on exit option is toggled on in the ScummVM options.

​https://github.com/scummvm/scummvm/pull/4827

[criezy]

The pull request has already been merged, so the issue should be fixed now.

[Thunderforge]

I've confirmed that the fix works. Thank you!