TETRAEDGE: Quitting from the main menu of Syberia freezes ScummVM if "Return to the launcher" is set

[Thunderforge]

When quitting from the main menu in Syberia (the first game), ScummVM freezes.

Reproduction Steps

1. In the ScummVM launcher, go to "Global Options" → "GUI" and then check "Return to the launcher when leaving the game"
2. Launch Syberia in ScummVM
3. On the main menu, click "Exit Game"
4. On the prompt, "Do you really want to quit?", click "OK"

The music will continue but ScummVM will freeze.

Versions Tested

• ScummVM 2.8.0 Daily 2023-03-14 macOS x64
• Syberia 1.0.2 macOS (GOG release)

[mduggan]

I can't reproduce this (or the corresponding Syberia 2 lockup #14329) on macOS - I even ran with address sanitizer to make sure nothing seems wrong. I wonder if there is a problem unique to Windows builds?

[Thunderforge]

I'm running on the macOS x64 builds, not the Windows builds. It's still happening consistently in the latest dailies. Let me know how I can help resolve it.

[Thunderforge]

I found out that this only happens if you go to the ScummVM Launcher -> Global Options -> GUI and then check "Return to the launcher when leaving the game". If that option is unchecked, there is no freeze.

[criezy]

I created a pull request that fixes this issue.
It also fixes a separate issue when the Ask for confirmation on exit option is toggled on in the ScummVM options.

​https://github.com/scummvm/scummvm/pull/4827

[criezy]

The pull request has already been merged, so the issue should be fixed now.

[Thunderforge]

I've confirmed that the fix works. Thank you!