SWORD1: Can't add game since new detection mode

[mjibe]

Hello,

my old CD version (PC/French) isn't recognized anymore by scummvm.

Here are the hashcodes reported by Scummvm (I'm on switch version if that matters, so handtyped hashcodes but doublechecked them) :

{"clusters/scripts.clu",  0, "72b10193714e8c6e4daca51791c0db0c", 1087984},
{"clusters/swordres.rif", 0, "c7df52094d590b568a4ed35b70390d9e", 58916},
{"clusters/text.clu",     0, "76f93f5feecc8915435105478f3c6615", 2705446},
{"smackshi/intro.smk",    0, "78e3ba96f33be8c2ef8feb46724cfef5", 11537716},

Regarding other detected versions (PC/CD/French also), only changes the "intro.smk" (hash and filesize).

It was a version released as a pack by Ubisoft (containing both 1 and 2 BS opus), all BS1 files were created in 1996, excepts this intro.smk created on 2000 (time of this release, which would explain also the ubisoft logo on start).

[mjibe]

I added 3 pictures, displaying the game pack which my BS1 version (and 2 if it matters) is extracted from (English and French covers, although mine is the French one).

[eperulli]

Same here with Italian old two-CDs version.
It worked like a charm before the last stable update
Output as follows:

The game in 'BrokenSword1' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sword1 engine: sword1-win-gb

{"scripts.clu", 0, "72b10193714e8c6e4daca51791c0db0c", 1088372},
{"smackshi/intro.smk", 0, "83060041aa155d802e51b7211b62ea2f", 13525252},
{"swordres.rif", 0, "239bdd76c405bad0f804a8ae5df4adb0", 59788},
{"text.clu", 0, "76f93f5feecc8915435105478f3c6615", 3188725},

[AndywinXp]

<edited out>

[lotharsm]

Thanks for the report!

The French version was added in ​https://github.com/scummvm/scummvm/commit/3582ebd3f7ff2e97fb5346729e67240393b0b5e1.

The alternative layout for the Italian version was added in commit ​https://github.com/scummvm/scummvm/commit/046e14ecc84396c65d42306369bd0fc626c0919e

Please re-test if possible.