#14308 closed defect (fixed)

GFX: Cursor: Regression - Cursor displays superfluous dots

Reported by: raziel- Owned by: lephilousophe
Priority: normal Component: Graphics
Version: Keywords: cursor, advmame, surfacesdl, scumm
Cc: Game: Monkey Island 1

Description

ScummVM 2.8.0git (Mar 8 2023 08:13:58)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC A/52 FreeType2 FriBiDi JPEG PNG GIF cloud (servers, local) ENet TinyGL OpenGL (with shaders)

Setting the "Graphics Mode" to "SDL Surface" and "Scaler" to AdvMame" shows some superfluous dots around the cross-hair cursor (like it was marking the four corners of the maximum cursor size).

See attached screenshots
(I tried to place it in lighter areas to see the dots)

Full Throttle (Version A English)
The Dig
The Secret of Monkey Island (CD/DOS/English)

AmigaOS4 - SDL2 - PPC - BE
gcc (adtools build 11.3.0) 11.3.0

Attachments (3)

The Dig_001.png (108.6 KB ) - added by raziel- 15 months ago.
Full Throttle (Version A English)_002.png (100.3 KB ) - added by raziel- 15 months ago.
Monkey Island 1 The Secret of Monkey Island (CD DOS English)_005.png (53.4 KB ) - added by raziel- 15 months ago.

Download all attachments as: .zip

Change History (7)

by raziel-, 15 months ago

Attachment: The Dig_001.png added

comment:2 by lephilousophe, 12 months ago

PR https://github.com/scummvm/scummvm/pull/5058 should fix this.
I am not sure it's a regression at all but didn't investigate more.

Scaler uses data from outside the surface which was initialized to 0 instead of using the key color (and get a transparent pixel).
Another way could be to duplicate the border on the outside.

comment:3 by raziel-, 12 months ago

@lephilousophe

Confirmed fixed, thank you

comment:4 by raziel-, 12 months ago

Owner: set to lephilousophe
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.