GFX: Cursor: Regression - Cursor displays superfluous dots

[raziel-]

ScummVM 2.8.0git (Mar 8 2023 08:13:58)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC A/52 FreeType2 FriBiDi JPEG PNG GIF cloud (servers, local) ENet TinyGL OpenGL (with shaders)

Setting the "Graphics Mode" to "SDL Surface" and "Scaler" to AdvMame" shows some superfluous dots around the cross-hair cursor (like it was marking the four corners of the maximum cursor size).

See attached screenshots
(I tried to place it in lighter areas to see the dots)

Full Throttle (Version A English)
The Dig
The Secret of Monkey Island (CD/DOS/English)

AmigaOS4 - SDL2 - PPC - BE
gcc (adtools build 11.3.0) 11.3.0

[lotharsm]

For reference: Related to ​https://forums.scummvm.org/viewtopic.php?p=98116

[lephilousophe]

PR ​https://github.com/scummvm/scummvm/pull/5058 should fix this.
I am not sure it's a regression at all but didn't investigate more.

Scaler uses data from outside the surface which was initialized to 0 instead of using the key color (and get a transparent pixel).
Another way could be to duplicate the border on the outside.

[raziel-]

@lephilousophe

Confirmed fixed, thank you