Opened 2 years ago

Closed 3 months ago

#14262 closed defect (fixed)

BACKENDS: OSXPPC: ScummVM fails to start without "millions of colors" setting

Reported by: jamie-marchant Owned by: dwatteau
Priority: normal Component: Port: Mac OS X
Version: Keywords: Mac, PowerPC, SDL
Cc: Game:

Description

It gives me this error when in terminal:
'Could not initialize SDL: Unsupported display mode!'

Change History (14)

comment:1 by dwatteau, 2 years ago

Component: CommonPort: Mac OS X
Owner: set to dwatteau
Resolution: assigned
Status: newpending
Summary: Scummvm 2.6.1 for Mac OS X.4 PPC does not runOSX: Scummvm 2.6.1 for Mac OS X.4 PPC does not run

comment:2 by dwatteau, 2 years ago

Thank you for reporting this.

Can you give me the output from the sw_vers command in the terminal (it gives the precise macOS version), and tell me which PPC computer you are using to test this? Maybe there's an issue with bigger screens or dual monitors (at the moment I only have PPC laptops), so the more context you give the easier it will be to work it out.

We've also just released a new 2.7.0 release for PPC, does it fix the problem, by chance?
https://downloads.scummvm.org/frs/scummvm/2.7.0/scummvm-2.7.0-macosx-ppc.dmg

comment:3 by dwatteau, 2 years ago

Also, please make sure that you have the "Millions of colors" setting enabled in your OSX system preferences.

comment:4 by jamie-marchant, 2 years ago

Yes the "Millions of colors" was the problem. I had it set to Thesonds.

comment:5 by jamie-marchant, 2 years ago

Owner: changed from dwatteau to jamie-marchant
Resolution: assignedfixed
Status: pendingclosed

comment:6 by jamie-marchant, 16 months ago

Resolution: fixed
Status: closednew

I am still getting this in 2.8.0 and think it's a bug because the error only shows up on a terminal instead of showing a dailog box that says "this software requires millions of colours." This is what other software on the OS would do.

comment:7 by dwatteau, 16 months ago

Summary: OSX: Scummvm 2.6.1 for Mac OS X.4 PPC does not runOSXPPC: ScummVM fails to start without "millions of colors" setting

in reply to:  6 comment:8 by dwatteau, 16 months ago

Replying to jamie-marchant:

I am still getting this in 2.8.0 and think it's a bug because the error only shows up on a terminal instead of showing a dailog box that says "this software requires millions of colours." This is what other software on the OS would do.

You're right in reopining this ticket; from a user perspective, it's hard to know that this setting needs to be changed. I'm also aware of another user on Twitter reporting this behavior.

I won't have the time to look into this and fix this for the moment, but if someone wants to provide a patch to improve this, it is of course welcome!

comment:9 by jamie-marchant, 16 months ago

I can't get Scummvm to compile on my old Mac, so it can't be me.

comment:10 by jamie-marchant, 8 months ago

I am not sure where to put this but this still happens on version 2.8.1.

comment:11 by sev-, 6 months ago

Summary: OSXPPC: ScummVM fails to start without "millions of colors" settingBACKENDS: OSXPPC: ScummVM fails to start without "millions of colors" setting

comment:12 by dwatteau, 3 months ago

Resolution: pending
Status: newpending

Hello,

I had a bit of time to look into this again.

@jamie-marchant: I saw that DOSBox 0.74-3-3 (see the universal .dmg file at <https://www.dosbox.com/download.php>) had the same problem, when setting the monitor to thousands of colors. Do you confirm this?

After some investigation, it looks like it may be an SDL regression from its 1.2.15 release, and not a ScummVM bug (i.e. you should be able to start ScummVM, even with a 16 bpp monitor, because most games support this, anyway. So it's not really a matter of adding a warning screen.)

I couldn't fix this for the official ScummVM 2.9.0 OSX PPC release, but I've made a test .dmg where I just relinked the 2.9.0 release against a patched SDL library.

https://github.com/dwatteau/scummvm/releases/download/v0.3.0b/scummvm-2.9.0-macosx-ppc-PATCHED-SDL-trac-bug-14262.dmg

@jamie-marchant: Can you test this patched release on your machine, with all monitor settings and games you can try, and report back any issue? If it's OK for you, it's going to be included in the next 2.9.1 or 2.10.0 release.

Thanks!

(technical notes about the SDL patch: I've removed the check at <https://github.com/libsdl-org/SDL-1.2/blob/0237f339e6bec39c56e1364787fabdb0245d478f/src/video/quartz/SDL_QuartzVideo.m#L291-L294>, which was added by upstream in commit <https://github.com/libsdl-org/SDL-1.2/commit/991bbb91c8cff091c7c1aee216e02949080756b6>, only part of SDL 1.2.15 and later. It looks like the latest SDL 1.2 releases were more likely to add regressions on earlier OSX.)

comment:13 by jamie-marchant, 3 months ago

Yes indeed Dosbox has the same issue and the ​https://github.com/dwatteau/scummvm/releases/download/v0.3.0b/scummvm-2.9.0-macosx-ppc-PATCHED-SDL-trac-bug-14262.dmg, works perfectly. Thank you very much.

comment:14 by dwatteau, 3 months ago

Owner: changed from jamie-marchant to dwatteau
Resolution: pendingfixed
Status: pendingclosed

Cool, thanks for testing so quickly! And sorry it took so look to fix that -- I've been very busy for the last two years, but it's getting better, now.

I'm marking this as fixed, then, and the next official OSX PPC releases will include this SDL patch by default.

Don't hesitate reporting any other issue that you may encounter on OSX PPC, I'm very interested in them :)

Cheers

Note: See TracTickets for help on using tickets.