GLK: SCOTT: fatal() and GlkExit() do return

[angstsmurf]

The Scott::fatal() method is supposed to print an error message and then exit, but seems to return after calling GlkExit(), which is also not supposed to return.

This causes an assert: "Assertion failed: (idx < _size), function operator[], file array.h, line 234" after showing the "Unsupported game! [press any key to exit]" message when trying to run an unsupported game.

The expected behaviour would be to either return to the launcher or exit ScummVM cleanly.

[hari01584]

How to reproduce this? What kind of games/files make scumm give unsupported game, please elaborate.

[angstsmurf]

I seems that pretty much any file you give a .saga extension will be detected by ScummVM as "Scott Adams IF Game".

[hari01584]

this should work - ​https://github.com/scummvm/scummvm/pull/4745

[angstsmurf]

Excellent!

Perhaps we should file a separate bug report or feature request about the fact that the detection code is too permissive in assuming that any .saga file is a valid Scott Adams game.

[hari01584]

Looked into the code, and it really has no checking for .saga, but not sure if this is by design(intentional) or actually a bug.

[tag2015]

Now that the PR has been merged I suppose this bugreport can be closed?

[angstsmurf]

Yes, seems to be working as intended now. Running an unsupported .saga game will now print an "Unsupported Game!" message and then exit ScummVM.

[tag2015]

Thanks for the reply! closing as fixed