Opened 12 months ago

Closed 9 months ago

#14255 closed defect (fixed)

GLK: SCOTT: Hulk: "System messages" not shown

Reported by: angstsmurf Owned by: angstsmurf
Priority: normal Component: Engine: GLK: Scott
Version: Keywords:
Cc: Game:

Description (last modified by angstsmurf)

In Questprobe featuring the Hulk, many "systems messages" (those common to all ScottFree games) such as "TELL ME WHAT TO DO" and "I'm in a " are not displayed.

There is some kind of memory corruption here, because when I tried to debug this by outputting all systems messages to the console as warnings, they suddenly started working just fine.

The messages are assigned to the Common::StringArray _sys in Globals at line 141 of load_game.cpp:

https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/load_game.cpp#L141

They are pointers to the array of const char g_sysDictZX defined at line 266 in ´game_info.cpp`:

https://github.com/scummvm/scummvm/blob/0be224bd5b949ee37ba3d68b3d04eec9c801b272/engines/glk/scott/game_info.cpp#L226

EDIT: An explanation for this bug, and a fix: https://github.com/scummvm/scummvm/pull/4728.


Attachments (2)

hulk_missing_text.png (425.8 KB ) - added by angstsmurf 12 months ago.
hulk_no_missing.png (450.9 KB ) - added by angstsmurf 12 months ago.
What it.is supposed to look like. Note the TELL ME WHAT TO DO? message.

Download all attachments as: .zip

Change History (6)

by angstsmurf, 12 months ago

Attachment: hulk_missing_text.png added

by angstsmurf, 12 months ago

Attachment: hulk_no_missing.png added

What it.is supposed to look like. Note the TELL ME WHAT TO DO? message.

comment:1 by angstsmurf, 12 months ago

Description: modified (diff)

comment:2 by angstsmurf, 12 months ago

Description: modified (diff)

comment:4 by lephilousophe, 9 months ago

Owner: set to angstsmurf
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.