SCUMM: Implement GUI for older Atari ST games

[GermanTribun]

System: Windows 10 x64
ScummVM: Newest 2.7.0git

Testing the implementation of the original GUI elements, which were claimed to be finished, I did notice several remaining problems, which are all located in older SCUMM games.

Maniac Mansion:
-The original GUI ist not implemented at all in the Atari ST version of the game.
-Additionally in the Atari version, the original cursor (Screenshot from an emulator added) is not implemented (and thus also not the Atari-version of the snail).

Zak:
-The original GUI ist not implemented at all in the Atari ST version of the game.
-Additionally in the Atari version, the original cursor (Screenshot from an emulator added) is not implemented (and thus also not the Atari-version of the snail).
-In the C64 version, the cursor for some reason also cycles through orange and yellow (Screenshot added), which is wrong (it doesn't happen in Maniac). Also, the sail is not white but dark gray (which also was correctly implemented in Maniac).
-In the FM-Towns version, the prompt when quitting the game is English, even though I use the German version.

Indy 3:
-When quitting the game, the prompt is in English, even though I played the German VGA version. (Screenshot added)

Loom:
-In the FM-Towns version, the German Version's quit prompt is a bit weird, in that pressing J or N does nothing, but return or Esc does. Additionally, J is alread pre-selcted. (Screenshot added) The EGA version has the prompt function properly.

[AndywinXp]

Thanks! Atari ST support for older titles, like the ones you mentioned was not implemented because of some technical issues.

Zak

-In the C64 version, the cursor for some reason also cycles through orange and yellow (Screenshot added), which is wrong (it doesn't happen in Maniac). Also, the sail is not white but dark gray (which also was correctly implemented in Maniac).

Thanks, I'll check what happened.

-In the FM-Towns version, the prompt when quitting the game is English, even though I use the German version.

Indy3:

-When quitting the game, the prompt is in English, even though I played the German VGA version. (Screenshot added)

These two are other cases of the prompts being hardcoded because they weren't there in the original, I'll see what I can do.

Loom:

-In the FM-Towns version, the German Version's quit prompt is a bit weird, in that pressing J or N does nothing, but return or Esc does. Additionally, J is alread pre-selcted. (Screenshot added) The EGA version has the prompt function properly.

This is because the strings should have the format "Want to quit? (Y/N)Y", while (from the actual game files, so this should happen even on the original) LOOM FM-Towns German yields "Want to quit? (Y/N)Y\r". As you can see, the character at the end of the string regulates which key should actually quit the game; in this case we have a "\r" character which corresponds... to the ENTER key :-) I'll have to put a workaround for this one.

[AndywinXp]

I solved most of these issues, except the FM-Towns ones which require the addition of the german versions in the detection tables.

I really can't reproduce this one for Indy3:

-When quitting the game, the prompt is in English, even though I played the German VGA version. (Screenshot added)

Are you sure that in the external game options in the ScummVM GUI the game language is set as german?

[GermanTribun]

Ah, the Indy3 problem was because ScummVM didn't auto-select the correct language and was on "default". I selected it manually and now it works.

Btw., when using the emulator I was reminded that on original hardware the cursor on the C64 vanished behind the characters (at least in Maniac), but I chalk that up to a hardware limitations.

[AndywinXp]

Ah yes, the C64 cursor thing is known. It appears to be a limitation dictated by the order in which the device had to draw the various layer; it's not easily reproducible here (if not impossible?), since the cursor is an overlay which is always on top of the screen (this is also why we can't stop the cursor from moving in older games during pause).

[GermanTribun]

Another issue was found by me.

While the German Floppy version of MI1 shows the correct prompt when using the gag-cheat to win instantly, on the German CD-version it's still in English. (I attached a screenshot)

Also, I was unable to check it due to a lack of a fitting save, but I know when using the win-cheat during the derby in FT, a prompt asks if you want to win the derby. Was that also properly translated?

[AndywinXp]

Thanks.

Both of these messages are taken from game files and are not hardcoded, so changing those is quite tricky and can quickly become a mess.

The FT message is translated properly, I just checked.

As for the win cheat message in MI1 CD, it's in english in every translated version of the game (I checked them in DOSBox). Unfortunately for now I have to avoid messing with that (the difference with the DOTT messages is that those were non-existent to begin with, these do exist and they do exist in the game files, so they are harder to change without breaking other stuff).

[AndywinXp]

Okay, I have implemented Atari ST too; as I said, the other issues are solvable by choosing the German language on the ScummVM GUI. Closing