SCUMM: Only partially translated original GUI in DOTT

[GermanTribun]

ScummVM: Newest 2.7.0.git
Game: DOTT German CD

As seen in the attached screenshot, the original GUI of DOTT in the German CD version is only partially translated, some English things do remain. That perhaps is due to DOTT originally no having the volume and text controls in the save panel, but still looks weird.

[dwatteau]

FWIW, the 2002 Aaron Giles interpreter for DOTT has the same behavior on the French release (while, as you said, the DOS release didn't put the volume and text controls there).

Sam & Max has the same behavior, even in the original DOS CD French release.

So it looks like the current behavior matches what the official releases did, but maybe we could improve on them by bringing the official translations used by some later title (such as The Dig or Full Throttle).

[GermanTribun]

Funny thing is, in German Sam&Max, the sound and text GUI was properly translated in the CD release. (don't know about the floppy one)

[AndywinXp]

I can confirm that those lines are untranslated because in the interpreter of reference for DOTT, they are hardcoded in english.

If you want to have a translation you'll have to provide the correct strings from Sam&Max in your language, so that we can insert those.

[GermanTribun]

Which I can't do since I'm not a programmer. That means until there is someone who can do so, this won't go anywhere (either for the German nor the French version).

[dwatteau]

I'll try having a look at it myself, but no promise on when it's going to happen.

[dwatteau]

I've submitted the following change:
​https://github.com/scummvm/scummvm/pull/4512

It basically just brings the Sam & Max menu CD strings into DOTT CD (floppy releases appear not to show them at all). DOTT hardcoded them while Sam & Max properly put them in a SCUMM script (no. 1-1) so they got official translations.

Regarding Sam & Max, my test above was done with the Aaron Giles interpreter. AndywinXp said that it also hardcoded the original English strings into the menu, even though translations *were* available for that one. So ScummVM already "unhides" the Sam & Max menu translations, and the PR above should do it for DOTT soon :)

[dwatteau]

This has now been integrated into our development version, and should be available in tomorrow's new daily build.

You'll have to enable both the "Enable the original GUI and Menu" and "Enable game-specific enhancements" options to see this change, since the hardcoded English strings were part of the original game.

Thanks.