Changes between Version 14 and Version 16 of Ticket #13933


Ignore:
Timestamp:
Nov 17, 2022, 1:08:33 AM (18 months ago)
Author:
m-kiewitz
Comment:

I have to talk with sluicebox about it, and also go through all the patches first.

And I would say most patches do fix game breaking things, so adding some flag about patches being needed doesn't really make sense, instead it should be the opposite. "Enhancement"-flag, or idk.

What about Space Quest 4 Skate-O-Rama fixes? You can call these game-breaking, but even in Original SCI there were ways to get through, it was simply a nightmare.

One really has to go through everything one-by-one. And what would make sense is also to create a wiki about all these fixes. I also just see that sluicebox added tons of QfG4 script patches, he knows these best. When we are already going through them all anyway...

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #13933 – Description

    v14 v16  
    11As of some recent version(s), bugs present in the original version of a variety of Sierra games were fixed in ScummVM, making their behavior different from the originals. Following the precedent set by [https://wiki.scummvm.org/index.php?title=SCUMM/Game_Enhancements&oldid=35577 these LucasArts games,] these bug fixes should use the “Enable game-specific enhancements” setting.
    22
    3 I don't know exactly which games are affected, but [https://www.benshoof.org/blog/super-sleuth this blog post] mentions “over one hundred original Sierra bugfixes” having been added as of version 2.1.0. It's probably possible to find the relevant games and changes by looking at the commits! It seems that most (if not all?) of the changes are in [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be disabled, rather than having to do it per enhancement.
     3I don't know exactly which games are affected, but [https://www.benshoof.org/blog/super-sleuth this blog post] mentions “over one hundred original Sierra bugfixes” being added in version 2.1.0. It's probably possible to find the relevant games and changes by looking at the commits! It seems that most (if not all?) of the changes are in [https://github.com/scummvm/scummvm/blob/master/engines/sci/engine/script_patches.cpp /engines/sci/engine/script_patches.cpp] – perhaps this whole file can be disabled, rather than having to do it per enhancement.
    44
    55I've filed this ticket under “Engine: SCI”, but it might affect some AGI games as well.