Opened 4 months ago

Closed 43 hours ago

#13897 closed defect (fixed)

TINSEL: DW2: Older savegames won't run on ScummVM 2.6.x

Reported by: dwatteau Owned by: somaen
Priority: high Component: Engine: Tinsel
Version: Keywords: saves
Cc: Game: Discworld II

Description

Two users are reporting save loading problems with (at least) the German version of Discworld 2:

https://forums.scummvm.org/viewtopic.php?t=16699

Trying to load older DW2 saves on ScummVM 2.6.0 fails with ERROR: Incompatible saved game, either on macOS, iPadOS or Debian sid.

New saves do not have this problem. The issue is also said to happen on our current Git HEAD.

Saves from the German version from user WindlePoons attached below.

Attachments (1)

dw2-de.005 (2.4 KB ) - added by dwatteau 4 months ago.
2010 dw2-de save that won't load in ScummVM 2.6.0

Download all attachments as: .zip

Change History (5)

by dwatteau, 4 months ago

Attachment: dw2-de.005 added

2010 dw2-de save that won't load in ScummVM 2.6.0

comment:1 by dwatteau, 5 weeks ago

Priority: normalhigh

Rising this to a higher priority for 2.7.0, since it’s a recent regression and breaking not-so-old save support is a bit of a major usability issue in my opinion. 2 users reported this problem on the forums

I tried having a look at it myself but didn’t go far…

comment:2 by somaen, 12 days ago

This was caused by the addition of the Noir SystemVars in eccf066b4be851e1e5cd699af0955fbf126b69e9

Suggested fix here:
https://github.com/scummvm/scummvm/pull/4661

This should generally lead to full backwards compatibility, for all old savegames, while also creating new savegames that will be readable by old versions.

comment:3 by somaen, 8 days ago

Owner: set to somaen
Resolution: pending
Status: newpending

comment:4 by dwatteau, 43 hours ago

Resolution: pendingfixed
Status: pendingclosed

With the PR above, it all looks good now, thanks!

It will also probably be cherry-picked for the 2.7.0 release.

Note: See TracTickets for help on using tickets.