Opened 17 months ago

Closed 3 months ago

#13890 closed defect (fixed)

AGS: Autosaves are inconsistently named in The Shivah

Reported by: Thunderforge Owned by: tag2015
Priority: normal Component: Engine: AGS
Version: Keywords: shivahkosher autosave
Cc: Game:

Description (last modified by Thunderforge)

In the original interpreter, all autosaves are labeled as *AUTOSAVE*.

In ScummVM, autosaves are inconsistently named as *AUTOSAVE*, AUTOSAVE, and Autosave, which results in more than one file of each showing up.

Versions Tested

Attachments (2)

Original Game.jpg (183.5 KB ) - added by Thunderforge 17 months ago.
ScummVM.png (28.4 KB ) - added by Thunderforge 17 months ago.

Download all attachments as: .zip

Change History (10)

by Thunderforge, 17 months ago

Attachment: Original Game.jpg added

by Thunderforge, 17 months ago

Attachment: ScummVM.png added

comment:1 by Thunderforge, 17 months ago

Description: modified (diff)

comment:2 by Thunderforge, 15 months ago

Keywords: shivahkosher added; shivah removed
Owner: set to Thunderforge
Resolution: outdated
Status: newclosed

This bug does occur in 2.6.1, but no longer occurs in Daily Build 2022-12-22.

comment:3 by Thunderforge, 15 months ago

Resolution: outdated
Status: closednew

Nevermind, I was premature. This does still happen in the latest nightly. It just takes more than one autosave for it to happen.

comment:4 by tag2015, 12 months ago

The save called "Autosave" is ScummVM's autosave. Since this game also uses an autosave managed by the engine (that uses a different saveslot), duplication is inevitable (it also happens in other games).
However, the duplication of AUTOSAVE and *AUTOSAVE* is indeed a bug, albeit a cosmetic one. The actual file is just one (slot 101) but for some reason the savelist shows it twice.

The same issue happens with Unavowed and some of the Blackwell games.

comment:5 by Thunderforge, 12 months ago

Is it feasible (or desirable) to disable the AGS autosave and just use the ScummVM one, thus eliminating the duplication?

in reply to:  5 comment:6 by tag2015, 11 months ago

Replying to Thunderforge:

Is it feasible (or desirable) to disable the AGS autosave and just use the ScummVM one, thus eliminating the duplication?

The biggest problem is that ScummVM's autosaves are timed, while ingame autosaves are often triggered by specific situations (when reaching a checkpoint, before a dangerous area, etc.). If we disable one or the other we lose that functionality.
Maybe the simplest solution (and that would apply to all engines, not just AGS) would be to rename scummvm's autosave to something like "(ScummVM Auto)" instead of "Autosave" so that it can be distinguishable.

comment:7 by tag2015, 3 months ago

Created PR https://github.com/scummvm/scummvm/pull/5454 addressing this issue

comment:8 by tag2015, 3 months ago

Owner: changed from Thunderforge to tag2015
Resolution: fixed
Status: newclosed

Should be fixed both in daily and in the upcoming 2.8.0

Note: See TracTickets for help on using tickets.