AGS: Autosaves are inconsistently named in The Shivah

[Thunderforge]

In the original interpreter, all autosaves are labeled as *AUTOSAVE*.

In ScummVM, autosaves are inconsistently named as *AUTOSAVE*, AUTOSAVE, and Autosave, which results in more than one file of each showing up.

Versions Tested

• ScummVM 2.6.0 (Windows x64)
• The Shivah (2013) ​from Steam

[Thunderforge]

This bug does occur in 2.6.1, but no longer occurs in Daily Build 2022-12-22.

[Thunderforge]

Nevermind, I was premature. This does still happen in the latest nightly. It just takes more than one autosave for it to happen.

[tag2015]

The save called "Autosave" is ScummVM's autosave. Since this game also uses an autosave managed by the engine (that uses a different saveslot), duplication is inevitable (it also happens in other games).
However, the duplication of AUTOSAVE and *AUTOSAVE* is indeed a bug, albeit a cosmetic one. The actual file is just one (slot 101) but for some reason the savelist shows it twice.

The same issue happens with Unavowed and some of the Blackwell games.

[Thunderforge]

Is it feasible (or desirable) to disable the AGS autosave and just use the ScummVM one, thus eliminating the duplication?

[tag2015]

Replying to Thunderforge:

Is it feasible (or desirable) to disable the AGS autosave and just use the ScummVM one, thus eliminating the duplication?

The biggest problem is that ScummVM's autosaves are timed, while ingame autosaves are often triggered by specific situations (when reaching a checkpoint, before a dangerous area, etc.). If we disable one or the other we lose that functionality.
Maybe the simplest solution (and that would apply to all engines, not just AGS) would be to rename scummvm's autosave to something like "(ScummVM Auto)" instead of "Autosave" so that it can be distinguishable.

[tag2015]

Created PR ​https://github.com/scummvm/scummvm/pull/5454 addressing this issue

[tag2015]

Should be fixed both in daily and in the upcoming 2.8.0