Opened 2 years ago

Closed 4 months ago

#13863 closed defect (fixed)

SCUMM/HE: Blue's Treasure Hunt - Breakout Minigame Editor crashes the program

Reported by: Thunderforge Owned by: AndywinXp
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Blue's Treasure Hunt

Description

This ticket was split off from #12505, posted by @cheatfreak47

I went ahead and went over my own copy of Blue's Clues: Blue's Treasure Hunt with a fine-toothed comb in the latest daily build ScummVM (at the time: windows-x86-64-master-cb14f43e), copying the files as instructed by the Wiki page and hunted for problems and came up with only a few.

Attached I will post some more or less completed savegames to try and assist with dev, but I don't know how useful they will be.

Worth noting that the actual game does work on modern Windows 10 with no issues, and can be windowed for comparison to scummVM.


On the breakout minigame on Disc 2, there is an editor. The moment you place a block or try to leave the menu, it writes a 0-byte .BRE file and a few kb .WIZ file at the user's save location and the program crashes. The expected behavior is that all this works properly and the user is able to save and play their own levels.

https://youtu.be/xXSNHZX0DDY?t=3132
This video here could be used as reference for what the Breakout Minigame's intended behavior is like.

Attachments (1)

Saved games.7z (3.3 KB ) - added by Thunderforge 2 years ago.

Download all attachments as: .zip

Change History (2)

by Thunderforge, 2 years ago

Attachment: Saved games.7z added

comment:1 by AndywinXp, 4 months ago

Owner: set to AndywinXp
Resolution: fixed
Status: newclosed

In 5924b381:

SCUMM: HE: Fix file handling opcodes issues

Unsurprisingly SPUTM handles files via integer file
handles, instead of SeekableStream objects :-P
This means that scripts can (and will!) occasionally
send out a -1 file handle which means that:

  • Write operations will result in NOP
  • Read operations will result in reading the value 0

Closes #13863:

"SCUMM/HE: Blue's Treasure Hunt - Breakout
Minigame Editor crashes the program"

This game was trying to open the -1 file handle,
and therefore it crashed while trying to access
position -1 in our array of file streams :'(

Note: See TracTickets for help on using tickets.