GameID's should be unique per game version + color bitness

[n1ckn4m3]

Right now cloud saving has a potential data sync issue due to how ScummVM handles multiple color bitness versions of the same game.

If I have 4 versions of SQ1SCI on my PC but only 2 on my tablet, "SQ1SCI" and "SQ1SCI-01" won't necessarily associate with the same versions of the game. This can be an issue when on the PC, "SQ1SCI" is the Floppy DOS VGA version but on the Tablet, "SQ1SCI" is the Floppy DOS EGA version.

This can be managed by ensuring that the game ID's match in the launcher per color bitness even if they wouldn't by default, but the lack of savegame compatible unique identifiers can cause ScummVM to not see save games when cloud sync is used with two different gamelists. If SQ1SCI 16 color could load SQ1SCI 256 color savegames (or vice-versa) this wouldn't be an issue, but because they can't and because the game ID is the base name for the savegames, this issue can occur.

It's not game-specific, it applies to all savegame filenames for games that have multiple editions that could use the same filename for saving and loading.

[n1ckn4m3]

Also I guess I shouldn't say the gameID's should or shouldn't be unique, just that the lack of them being unique per game and color bitness coupled with ScummVM using the GameID as the basename for the save game file creates this issue.

[sev-]

Unfortunately, enhancing all of our detection entries with such information is impractical. E.g. we would need to provide extra info for the target generation.

The chances that somebody legally owns multiple versions are very, very small. So, in this case, the manual target rename is the way to go.